Thread: Translations: Newline / Whitespace Fix
Good morning pgAdmin-hackers, I removed three occurences of unnecessary newlines / whitespaces in __init__.py files, which prevented alphabetical sorting of translatable strings in poEdit. Question: In such .diffs like the attached, should I include the updated and compiled strings in .pot and .mo files? Greetings, Jonas Thelemann
Attachment
Hi On Sun, Mar 26, 2017 at 8:15 PM, Jonas Thelemann <e-mail@jonas-thelemann.de> wrote: > Good morning pgAdmin-hackers, > > I removed three occurences of unnecessary newlines / whitespaces in > __init__.py files, which prevented alphabetical sorting of translatable > strings in poEdit. Thanks - applied. > Question: In such .diffs like the attached, should I include the updated and > compiled strings in .pot and .mo files? No, I'll typically re-merge/rebuild them as part of the commit. However - there's a bug at the moment due to some in-progress long term work to move javascript translations into the client, which is preventing me doing that. I'll ping the person who was going to get it sorted to see if I can speed up the fix. Thanks! -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
> No, I'll typically re-merge/rebuild them as part of the commit. > > However - there's a bug at the moment due to some in-progress long > term work to move javascript translations into the client, which is > preventing me doing that. > > I'll ping the person who was going to get it sorted to see if I can > speed up the fix. Ok, I'll send .pot and .mo files too as long as this isn't fixed, ok? Just tell me when that is :)
On Sun, Mar 26, 2017 at 8:38 PM, Jonas Thelemann <e-mail@jonas-thelemann.de> wrote: >> No, I'll typically re-merge/rebuild them as part of the commit. >> >> However - there's a bug at the moment due to some in-progress long >> term work to move javascript translations into the client, which is >> preventing me doing that. >> >> I'll ping the person who was going to get it sorted to see if I can >> speed up the fix. > > Ok, I'll send .pot and .mo files too as long as this isn't fixed, ok? Just > tell me when that is :) Yeah, I guess that could work. The issue at the moment is that I cannot update the template without losing messages that have been converted to the new code. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company