Thread: [pgAdmin4][patch] extract generate_url function from node.js and collection.js
[pgAdmin4][patch] extract generate_url function from node.js and collection.js
From
Violet Cheng
Date:
Hi hackers,
We tried to extract and refactor generate_url function in node.js and collection.js. Please see the patch attached.
Thanks,
Violet & Sarah
Attachment
Re: [pgAdmin4][patch] extract generate_url function from node.js and collection.js
From
Ashesh Vashi
Date:
On Thu, Aug 10, 2017 at 1:15 PM, Violet Cheng <vcheng@pivotal.io> wrote:
Khushboo,Hi hackers,We tried to extract and refactor generate_url function in node.js and collection.js. Please see the patch attached.
Please review this one.
Thanks,Violet & Sarah
Re: [pgAdmin4][patch] extract generate_url function from node.js and collection.js
From
Violet Cheng
Date:
Hi,
Is there any update on this patch? Will it be committed soon?
Thanks,
Violet
On Fri, Aug 11, 2017 at 2:38 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
On Thu, Aug 10, 2017 at 1:15 PM, Violet Cheng <vcheng@pivotal.io> wrote:Khushboo,Hi hackers,We tried to extract and refactor generate_url function in node.js and collection.js. Please see the patch attached.Please review this one.Thanks,Violet & Sarah
Re: [pgAdmin4][patch] extract generate_url function from node.js and collection.js
From
Khushboo Vashi
Date:
Hi,
The patch looks good to me.
Thanks,
Khushboo
On Fri, Aug 11, 2017 at 12:08 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
On Thu, Aug 10, 2017 at 1:15 PM, Violet Cheng <vcheng@pivotal.io> wrote:Khushboo,Hi hackers,We tried to extract and refactor generate_url function in node.js and collection.js. Please see the patch attached.Please review this one.
Thanks,Violet & Sarah
Re: [pgAdmin4][patch] extract generate_url function from node.js and collection.js
From
Ashesh Vashi
Date:
On Wed, Aug 16, 2017 at 4:20 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,The patch looks good to me.Thanks,KhushbooOn Fri, Aug 11, 2017 at 12:08 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote: On Thu, Aug 10, 2017 at 1:15 PM, Violet Cheng <vcheng@pivotal.io> wrote:Hi hackers,We tried to extract and refactor generate_url function in node.js and collection.js. Please see the patch attached.
Thanks - committed!
--
Thanks & Regards,
Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
Khushboo,Please review this one.
Thanks,Violet & Sarah
Re: [pgAdmin4][patch] extract generate_url function from node.js and collection.js
From
Violet Cheng
Date:
Great! Thanks a lot.
Violet
On Fri, Aug 18, 2017 at 12:13 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
On Wed, Aug 16, 2017 at 4:20 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote: Hi,The patch looks good to me.Thanks,KhushbooOn Fri, Aug 11, 2017 at 12:08 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote: On Thu, Aug 10, 2017 at 1:15 PM, Violet Cheng <vcheng@pivotal.io> wrote:Hi hackers,We tried to extract and refactor generate_url function in node.js and collection.js. Please see the patch attached.Thanks - committed!
--Thanks & Regards,
Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
Khushboo,Please review this one.Thanks,Violet & Sarah