Re: [pgAdmin4][patch] extract generate_url function from node.js and collection.js - Mailing list pgadmin-hackers

From Ashesh Vashi
Subject Re: [pgAdmin4][patch] extract generate_url function from node.js and collection.js
Date
Msg-id CAG7mmowQ65_ptRgWWD0cdkiE_+er-Hro2xtFcxenXDYQhY3Lfw@mail.gmail.com
Whole thread Raw
In response to Re: [pgAdmin4][patch] extract generate_url function from node.js and collection.js  (Khushboo Vashi <khushboo.vashi@enterprisedb.com>)
Responses Re: [pgAdmin4][patch] extract generate_url function from node.js and collection.js  (Violet Cheng <vcheng@pivotal.io>)
List pgadmin-hackers
On Wed, Aug 16, 2017 at 4:20 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,

The patch looks good to me. 
Thanks,
Khushboo

On Fri, Aug 11, 2017 at 12:08 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
On Thu, Aug 10, 2017 at 1:15 PM, Violet Cheng <vcheng@pivotal.io> wrote:
Hi hackers,

We tried to extract and refactor generate_url function in node.js and collection.js. Please see the patch attached.
Thanks - committed!


--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company


Khushboo,

Please review this one. 

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company


http://www.linkedin.com/in/asheshvashi


Thanks,
Violet & Sarah



pgadmin-hackers by date:

Previous
From: Ashesh Vashi
Date:
Subject: pgAdmin 4 commit: Extract the generate_url(..) function from node.js,a
Next
From: pgAdmin 4 Jenkins
Date:
Subject: Build failed in Jenkins: pgadmin4-master-python33 #285