Re: [pgAdmin4][patch] extract generate_url function from node.js and collection.js - Mailing list pgadmin-hackers

From Violet Cheng
Subject Re: [pgAdmin4][patch] extract generate_url function from node.js and collection.js
Date
Msg-id CAK588uQWMjo4LZ-g0-SRdLPwgVh2sccyRrrSVZ-xJTxnD2jB+g@mail.gmail.com
Whole thread Raw
In response to Re: [pgAdmin4][patch] extract generate_url function from node.js and collection.js  (Ashesh Vashi <ashesh.vashi@enterprisedb.com>)
List pgadmin-hackers
Great! Thanks a lot.

Violet

On Fri, Aug 18, 2017 at 12:13 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
On Wed, Aug 16, 2017 at 4:20 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,

The patch looks good to me. 
Thanks,
Khushboo

On Fri, Aug 11, 2017 at 12:08 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
On Thu, Aug 10, 2017 at 1:15 PM, Violet Cheng <vcheng@pivotal.io> wrote:
Hi hackers,

We tried to extract and refactor generate_url function in node.js and collection.js. Please see the patch attached.
Thanks - committed!


--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company


Khushboo,

Please review this one. 

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company


http://www.linkedin.com/in/asheshvashi


Thanks,
Violet & Sarah




pgadmin-hackers by date:

Previous
From: pgAdmin 4 Jenkins
Date:
Subject: Jenkins build is back to normal : pgadmin4-master-python36 #281
Next
From: Ashesh Vashi
Date:
Subject: pgAdmin 4 commit: Fixes #2567 - Use the proper database connection tof