Thread: [pgAdmin4][patch] Fix feature tests failure

Hi Hackers,

This patch is about fixing the feature tests failure.

Thanks,

Wenlin, Violet & Hao

Hi Hackers!

Could someone review this patch, please?

Thanks so much!
Sarah

On Mon, Aug 7, 2017 at 4:42 PM, Wenlin Zhang <wzhang@pivotal.io> wrote:

Hi Hackers,

This patch is about fixing the feature tests failure.

Thanks,

Wenlin, Violet & Hao

Hi Sarah,

I am doing this and didn't reply on this thread as we are discussing this on the another thread (the History Update patch).

Thanks,

Khushboo

On Wed, Aug 9, 2017 at 9:10 AM, Sarah McAlear <smcalear@pivotal.io> wrote:

Hi Hackers!

Could someone review this patch, please?

Thanks so much!
Sarah

On Mon, Aug 7, 2017 at 4:42 PM, Wenlin Zhang <wzhang@pivotal.io> wrote:

Hi Hackers,

This patch is about fixing the feature tests failure.

Thanks,

Wenlin, Violet & Hao

As Sarah discussed with Khushboo on slack (pgadminhackers.slack.com for those who would like to join) yesterday, these errors seem to occur only on her Ubuntu system. We have not replicated them on Mac. But they exist before this patch, also.

We notice that copy/paste functionality is being tested in two feature tests, the query_tool_journey_test.py and copy_selected_query_results_feature_test.py. Perhaps we only need to test this behavior in one of the tests? 

We've confirmed that the patch is able to be applied against the current state of master without any changes after yesterday's commits.

Thanks,

Wenlin and Matt