Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgAdmin4][patch] Fix feature tests failure - Mailing list pgadmin-hackers

From Violet Cheng
Subject Re: [pgAdmin4][patch] Fix feature tests failure
Date
Msg-id CAK588uRQH3sL3zVOr67LdjhU02PJwPfBYNQkU9GQcyFQ_30xNQ@mail.gmail.com
Whole thread Raw
In response to Re: [pgAdmin4][patch] Fix feature tests failure  (Wenlin Zhang <wzhang@pivotal.io>)
Responses Re: [pgAdmin4][patch] Fix feature tests failure
List pgadmin-hackers
Tree view
Hi,

Is there any update on this patch? Will it be committed soon?

Thanks,
Violet

On Thu, Aug 10, 2017 at 11:32 AM, Wenlin Zhang <wzhang@pivotal.io> wrote:

As Sarah discussed with Khushboo on slack (pgadminhackers.slack.com for those who would like to join) yesterday, these errors seem to occur only on her Ubuntu system. We have not replicated them on Mac. But they exist before this patch, also.

We notice that copy/paste functionality is being tested in two feature tests, the query_tool_journey_test.py and copy_selected_query_results_feature_test.py. Perhaps we only need to test this behavior in one of the tests? 

We've confirmed that the patch is able to be applied against the current state of master without any changes after yesterday's commits.

Thanks,

Wenlin and Matt


pgadmin-hackers by date:

Previous
From: Shirley Wang
Date:
Subject: Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor
Next
From: Violet Cheng
Date:
Subject: Re: [pgadmin4][patch] Fix the style of the alert whenconnecting/disconnecting from a server