Thread: [HACKERS] Misleading comment in slru.h
Hi hackers, As mentioned in another thread[1], slru.h says: * Note: slru.c currently assumes that segment file names will be four hex * digits. This sets a lower bound on the segment size (64K transactions * for 32-bit TransactionIds). That comment is out of date: commit 638cf09e extended SLRUs to support 5 character names to support pg_multixact and commit 73c986ad extended support to 6 character SLRU file names for pg_commit_ts. Should we just remove that comment? [1] https://www.postgresql.org/message-id/CAEepm%3D1UdqnmHTikNBsBYsSDuk3nc9rXFPbeWYrbA2iM6K9q2w%40mail.gmail.com -- Thomas Munro http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Attachment
On 6/27/17 01:43, Thomas Munro wrote: > As mentioned in another thread[1], slru.h says: > > * Note: slru.c currently assumes that segment file names will be four hex > * digits. This sets a lower bound on the segment size (64K transactions > * for 32-bit TransactionIds). > > That comment is out of date: commit 638cf09e extended SLRUs to support > 5 character names to support pg_multixact and commit 73c986ad extended > support to 6 character SLRU file names for pg_commit_ts. > > Should we just remove that comment? done -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services