Postgres Pro
Downloads
Home   >   mailing lists

Re: [HACKERS] Misleading comment in slru.h - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: [HACKERS] Misleading comment in slru.h
Date
Msg-id c6f518db-1446-0f48-5c6c-ebeef92f0a1c@2ndquadrant.com
Whole thread Raw
In response to [HACKERS] Misleading comment in slru.h  (Thomas Munro <thomas.munro@enterprisedb.com>)
List pgsql-hackers
Tree view 
On 6/27/17 01:43, Thomas Munro wrote:
> As mentioned in another thread[1], slru.h says:
> 
>   * Note: slru.c currently assumes that segment file names will be four hex
>   * digits.  This sets a lower bound on the segment size (64K transactions
>   * for 32-bit TransactionIds).
> 
> That comment is out of date: commit 638cf09e extended SLRUs to support
> 5 character names to support pg_multixact and commit 73c986ad extended
> support to 6 character SLRU file names for pg_commit_ts.
> 
> Should we just remove that comment?

done

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: [HACKERS] Incorrect mentions to pg_xlog in walmethods.c/h
Next
From: Peter Eisentraut
Date:
Subject: Re: [HACKERS] Typo in comment in xlog.c: ReadRecord