Postgres Pro
Downloads
Home   >   mailing lists

[HACKERS] Misleading comment in slru.h - Mailing list pgsql-hackers

From Thomas Munro
Subject [HACKERS] Misleading comment in slru.h
Date
Msg-id CAEepm=3-LAqqwgO30W6icgW2pP+N4zDFS6CTbDL-K9YBv4wx1g@mail.gmail.com
Whole thread Raw
Responses Re: [HACKERS] Misleading comment in slru.h  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
List pgsql-hackers
Tree view 
Hi hackers,

As mentioned in another thread[1], slru.h says:

  * Note: slru.c currently assumes that segment file names will be four hex
  * digits.  This sets a lower bound on the segment size (64K transactions
  * for 32-bit TransactionIds).

That comment is out of date: commit 638cf09e extended SLRUs to support
5 character names to support pg_multixact and commit 73c986ad extended
support to 6 character SLRU file names for pg_commit_ts.

Should we just remove that comment?

[1] https://www.postgresql.org/message-id/CAEepm%3D1UdqnmHTikNBsBYsSDuk3nc9rXFPbeWYrbA2iM6K9q2w%40mail.gmail.com

-- 
Thomas Munro
http://www.enterprisedb.com

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: [HACKERS] Incorrect mentions to pg_xlog in walmethods.c/h
Next
From: Mithun Cy
Date:
Subject: Re: [HACKERS] Proposal : For Auto-Prewarm.