Thread: Re: [HACKERS] Remove pg_stat_progress_vacuum from Table 28.2
On Tue, Apr 4, 2017 at 10:19 AM, Amit Langote <Langote_Amit_f8@lab.ntt.co.jp> wrote: > It seems pg_stat_progress_vacuum is not supposed to appear in the table > titled "Collected Statistics Views". It was added by c16dc1aca. Attached > patch fixes that. Instead, it should appear in the table of "Dynamic Statistics Views" because it reports dynamic info, i.e., progress, about VACUUM activity? Regards, -- Fujii Masao
On 2017/04/07 0:56, Fujii Masao wrote: > On Tue, Apr 4, 2017 at 10:19 AM, Amit Langote > <Langote_Amit_f8@lab.ntt.co.jp> wrote: >> It seems pg_stat_progress_vacuum is not supposed to appear in the table >> titled "Collected Statistics Views". It was added by c16dc1aca. Attached >> patch fixes that. > > Instead, it should appear in the table of "Dynamic Statistics Views" > because it reports dynamic info, i.e., progress, about VACUUM activity? I thought the same at first, but then realized we have a entirely separate section 28.4. Progress Reporting. So it may not be necessary to keep it anywhere in 28.2. In fact I also proposed [1] to move the descriptions of "Dynamic Statistics Views" to a new section within the same chapter. Thanks, Amit [1] https://www.postgresql.org/message-id/70cd6b98-7c3f-e368-04ed-e053d18b7d81%40lab.ntt.co.jp
On Fri, Apr 7, 2017 at 9:53 AM, Amit Langote <Langote_Amit_f8@lab.ntt.co.jp> wrote: > On 2017/04/07 0:56, Fujii Masao wrote: >> On Tue, Apr 4, 2017 at 10:19 AM, Amit Langote >> <Langote_Amit_f8@lab.ntt.co.jp> wrote: >>> It seems pg_stat_progress_vacuum is not supposed to appear in the table >>> titled "Collected Statistics Views". It was added by c16dc1aca. Attached >>> patch fixes that. >> >> Instead, it should appear in the table of "Dynamic Statistics Views" >> because it reports dynamic info, i.e., progress, about VACUUM activity? > > I thought the same at first, but then realized we have a entirely separate > section 28.4. Progress Reporting. Yes, but I don't think that removing that from 28.2 is an improvement for users. Regards, -- Fujii Masao
On 2017/04/12 0:22, Fujii Masao wrote: > On Fri, Apr 7, 2017 at 9:53 AM, Amit Langote > <Langote_Amit_f8@lab.ntt.co.jp> wrote: >> On 2017/04/07 0:56, Fujii Masao wrote: >>> On Tue, Apr 4, 2017 at 10:19 AM, Amit Langote >>> <Langote_Amit_f8@lab.ntt.co.jp> wrote: >>>> It seems pg_stat_progress_vacuum is not supposed to appear in the table >>>> titled "Collected Statistics Views". It was added by c16dc1aca. Attached >>>> patch fixes that. >>> >>> Instead, it should appear in the table of "Dynamic Statistics Views" >>> because it reports dynamic info, i.e., progress, about VACUUM activity? >> >> I thought the same at first, but then realized we have a entirely separate >> section 28.4. Progress Reporting. > > Yes, but I don't think that removing that from 28.2 is an improvement > for users. Perhaps you're right. Here's a patch that moves pg_stat_progress_vacuum to the Dynamic Statistics Views table. Thanks, Amit -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Attachment
On Wed, Apr 12, 2017 at 10:32 AM, Amit Langote <Langote_Amit_f8@lab.ntt.co.jp> wrote: > On 2017/04/12 0:22, Fujii Masao wrote: >> On Fri, Apr 7, 2017 at 9:53 AM, Amit Langote >> <Langote_Amit_f8@lab.ntt.co.jp> wrote: >>> On 2017/04/07 0:56, Fujii Masao wrote: >>>> On Tue, Apr 4, 2017 at 10:19 AM, Amit Langote >>>> <Langote_Amit_f8@lab.ntt.co.jp> wrote: >>>>> It seems pg_stat_progress_vacuum is not supposed to appear in the table >>>>> titled "Collected Statistics Views". It was added by c16dc1aca. Attached >>>>> patch fixes that. >>>> >>>> Instead, it should appear in the table of "Dynamic Statistics Views" >>>> because it reports dynamic info, i.e., progress, about VACUUM activity? >>> >>> I thought the same at first, but then realized we have a entirely separate >>> section 28.4. Progress Reporting. >> >> Yes, but I don't think that removing that from 28.2 is an improvement >> for users. > > Perhaps you're right. Here's a patch that moves pg_stat_progress_vacuum > to the Dynamic Statistics Views table. Thanks for the patch! Pushed. Regards, -- Fujii Masao
On 2017/04/13 12:11, Fujii Masao wrote: > On Wed, Apr 12, 2017 at 10:32 AM, Amit Langote > <Langote_Amit_f8@lab.ntt.co.jp> wrote: >> On 2017/04/12 0:22, Fujii Masao wrote: >>> On Fri, Apr 7, 2017 at 9:53 AM, Amit Langote >>> <Langote_Amit_f8@lab.ntt.co.jp> wrote: >>>> On 2017/04/07 0:56, Fujii Masao wrote: >>>>> On Tue, Apr 4, 2017 at 10:19 AM, Amit Langote >>>>> <Langote_Amit_f8@lab.ntt.co.jp> wrote: >>>>>> It seems pg_stat_progress_vacuum is not supposed to appear in the table >>>>>> titled "Collected Statistics Views". It was added by c16dc1aca. Attached >>>>>> patch fixes that. >>>>> >>>>> Instead, it should appear in the table of "Dynamic Statistics Views" >>>>> because it reports dynamic info, i.e., progress, about VACUUM activity? >>>> >>>> I thought the same at first, but then realized we have a entirely separate >>>> section 28.4. Progress Reporting. >>> >>> Yes, but I don't think that removing that from 28.2 is an improvement >>> for users. >> >> Perhaps you're right. Here's a patch that moves pg_stat_progress_vacuum >> to the Dynamic Statistics Views table. > > Thanks for the patch! Pushed. Thanks, Regards, Amit