Re: [HACKERS] Remove pg_stat_progress_vacuum from Table 28.2 - Mailing list pgsql-hackers

From Amit Langote
Subject Re: [HACKERS] Remove pg_stat_progress_vacuum from Table 28.2
Date
Msg-id c5981dfd-6481-9183-6f67-2a65af3ec1ae@lab.ntt.co.jp
Whole thread Raw
In response to Re: [HACKERS] Remove pg_stat_progress_vacuum from Table 28.2  (Fujii Masao <masao.fujii@gmail.com>)
List pgsql-hackers
On 2017/04/13 12:11, Fujii Masao wrote:
> On Wed, Apr 12, 2017 at 10:32 AM, Amit Langote
> <Langote_Amit_f8@lab.ntt.co.jp> wrote:
>> On 2017/04/12 0:22, Fujii Masao wrote:
>>> On Fri, Apr 7, 2017 at 9:53 AM, Amit Langote
>>> <Langote_Amit_f8@lab.ntt.co.jp> wrote:
>>>> On 2017/04/07 0:56, Fujii Masao wrote:
>>>>> On Tue, Apr 4, 2017 at 10:19 AM, Amit Langote
>>>>> <Langote_Amit_f8@lab.ntt.co.jp> wrote:
>>>>>> It seems pg_stat_progress_vacuum is not supposed to appear in the table
>>>>>> titled "Collected Statistics Views".  It was added by c16dc1aca.  Attached
>>>>>> patch fixes that.
>>>>>
>>>>> Instead, it should appear in the table of "Dynamic Statistics Views"
>>>>> because it reports dynamic info, i.e., progress, about VACUUM activity?
>>>>
>>>> I thought the same at first, but then realized we have a entirely separate
>>>> section 28.4. Progress Reporting.
>>>
>>> Yes, but I don't think that removing that from 28.2 is an improvement
>>> for users.
>>
>> Perhaps you're right.  Here's a patch that moves pg_stat_progress_vacuum
>> to the Dynamic Statistics Views table.
> 
> Thanks for the patch! Pushed.

Thanks,

Regards,
Amit




pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: [HACKERS] logical replication and PANIC during shutdowncheckpoint in publisher
Next
From: Amit Kapila
Date:
Subject: Re: [HACKERS] Inadequate parallel-safety check for SubPlans