Re: [HACKERS] Remove pg_stat_progress_vacuum from Table 28.2 - Mailing list pgsql-hackers

From Amit Langote
Subject Re: [HACKERS] Remove pg_stat_progress_vacuum from Table 28.2
Date
Msg-id 2d80555e-ca63-99db-bf0f-ecf34e0d9ccb@lab.ntt.co.jp
Whole thread Raw
In response to Re: [HACKERS] Remove pg_stat_progress_vacuum from Table 28.2  (Fujii Masao <masao.fujii@gmail.com>)
Responses Re: [HACKERS] Remove pg_stat_progress_vacuum from Table 28.2  (Fujii Masao <masao.fujii@gmail.com>)
List pgsql-hackers
On 2017/04/12 0:22, Fujii Masao wrote:
> On Fri, Apr 7, 2017 at 9:53 AM, Amit Langote
> <Langote_Amit_f8@lab.ntt.co.jp> wrote:
>> On 2017/04/07 0:56, Fujii Masao wrote:
>>> On Tue, Apr 4, 2017 at 10:19 AM, Amit Langote
>>> <Langote_Amit_f8@lab.ntt.co.jp> wrote:
>>>> It seems pg_stat_progress_vacuum is not supposed to appear in the table
>>>> titled "Collected Statistics Views".  It was added by c16dc1aca.  Attached
>>>> patch fixes that.
>>>
>>> Instead, it should appear in the table of "Dynamic Statistics Views"
>>> because it reports dynamic info, i.e., progress, about VACUUM activity?
>>
>> I thought the same at first, but then realized we have a entirely separate
>> section 28.4. Progress Reporting.
> 
> Yes, but I don't think that removing that from 28.2 is an improvement
> for users.

Perhaps you're right.  Here's a patch that moves pg_stat_progress_vacuum
to the Dynamic Statistics Views table.

Thanks,
Amit

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Attachment

pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: [HACKERS] Some thoughts about SCRAM implementation
Next
From: Noah Misch
Date:
Subject: Re: [HACKERS] error handling in RegisterBackgroundWorker