Thread: [HACKERS] Small fix to postgresql.conf.sample's comment on max_parallel_workers
[HACKERS] Small fix to postgresql.conf.sample's comment on max_parallel_workers
From
David Rowley
Date:
While scanning over postgresql.conf I happened to notice something that didn't ring quite true about max_parallel_workers. The comment confuses worker_processes with parallel workers. The attached aims to put this right. -- David Rowley http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Attachment
Re: [HACKERS] Small fix to postgresql.conf.sample's comment on max_parallel_workers
From
Amit Kapila
Date:
On Tue, Mar 7, 2017 at 6:39 AM, David Rowley <david.rowley@2ndquadrant.com> wrote: > While scanning over postgresql.conf I happened to notice something > that didn't ring quite true about max_parallel_workers. The comment > confuses worker_processes with parallel workers. > +1. How about changing the description of max_parallel_workers_per_gather to "taken from max_worker_processes, limited by max_parallel_workers"? -- With Regards, Amit Kapila. EnterpriseDB: http://www.enterprisedb.com
Re: [HACKERS] Small fix to postgresql.conf.sample's comment on max_parallel_workers
From
David Rowley
Date:
On 7 March 2017 at 15:21, Amit Kapila <amit.kapila16@gmail.com> wrote: > +1. How about changing the description of > max_parallel_workers_per_gather to "taken from max_worker_processes, > limited by max_parallel_workers"? Thanks for looking. Seems more accurate to say that it's "taken from max_parallel_workers", maybe. You can't "take" more than what's there, so perhaps the extra text is not required. Patch attached. -- David Rowley http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Attachment
Re: [HACKERS] Small fix to postgresql.conf.sample's comment on max_parallel_workers
From
Amit Kapila
Date:
On Tue, Mar 7, 2017 at 8:02 AM, David Rowley <david.rowley@2ndquadrant.com> wrote: > On 7 March 2017 at 15:21, Amit Kapila <amit.kapila16@gmail.com> wrote: >> +1. How about changing the description of >> max_parallel_workers_per_gather to "taken from max_worker_processes, >> limited by max_parallel_workers"? > > Thanks for looking. > > Seems more accurate to say that it's "taken from > max_parallel_workers", maybe. > I thought of saying similar to what we have in docs, however the way you have written works for me. -- With Regards, Amit Kapila. EnterpriseDB: http://www.enterprisedb.com
Re: [HACKERS] Small fix to postgresql.conf.sample's comment on max_parallel_workers
From
Robert Haas
Date:
On Tue, Mar 7, 2017 at 7:42 AM, Amit Kapila <amit.kapila16@gmail.com> wrote: > On Tue, Mar 7, 2017 at 8:02 AM, David Rowley > <david.rowley@2ndquadrant.com> wrote: >> On 7 March 2017 at 15:21, Amit Kapila <amit.kapila16@gmail.com> wrote: >>> +1. How about changing the description of >>> max_parallel_workers_per_gather to "taken from max_worker_processes, >>> limited by max_parallel_workers"? >> >> Thanks for looking. >> >> Seems more accurate to say that it's "taken from >> max_parallel_workers", maybe. >> > > I thought of saying similar to what we have in docs, however the way > you have written works for me. Committed. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Re: [HACKERS] Small fix to postgresql.conf.sample's comment on max_parallel_workers
From
David Rowley
Date:
On 8 March 2017 at 09:32, Robert Haas <robertmhaas@gmail.com> wrote: > Committed. Thanks! -- David Rowley http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training & Services