Thread: Re: [HACKERS] [BUGS] Seems bug in postgres_fdw?

Re: [HACKERS] [BUGS] Seems bug in postgres_fdw?

From
"Rader, David"
Date:

On Mon, Feb 27, 2017 at 10:10 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
Sachin Kotwal <kotsachin@gmail.com> writes:
> Here , Why postgresql takes different time when remote table and foreign
> table have different definition for timestamp column?

I believe postgres_fdw sets the timezone in its remote session to UTC
for predictability of results.  Your table definition is really at fault
for being dependent on what the session timezone is.

Personally I'd make the ins_ts column be timestamp with time zone, but
if you really don't want to do that, you could consider making the default
expression be "current_timestamp AT TIME ZONE 'something'" to force the
rotated value to be in a particular zone.

                        regards, tom lane



Tom -

Attached is a doc patch that updates the documentation for postgres-fdw to include the actual values for the 4 session variables that are set. Does that make sense to clarify?

Thanks
-Dave

Attachment

Re: [HACKERS] [BUGS] Seems bug in postgres_fdw?

From
Robert Haas
Date:
On Thu, Mar 2, 2017 at 3:28 AM, Rader, David <davidr@openscg.com> wrote:
> Attached is a doc patch that updates the documentation for postgres-fdw to
> include the actual values for the 4 session variables that are set. Does
> that make sense to clarify?

From my point of view, this would be a sensible thing to document,
although I feel like the grammar is not quite right, because after
"establishes remote session settings for the parameters" my brain
expects a list of parameters rather than a list of parameters and the
corresponding values.  I think it reads better if you change "for the
parameters" to "for various parameters".

</nitpicking>

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



Re: [HACKERS] [BUGS] Seems bug in postgres_fdw?

From
"Rader, David"
Date:

On Sat, Mar 4, 2017 at 12:52 AM, Robert Haas <robertmhaas@gmail.com> wrote:
On Thu, Mar 2, 2017 at 3:28 AM, Rader, David <davidr@openscg.com> wrote:
> Attached is a doc patch that updates the documentation for postgres-fdw to
> include the actual values for the 4 session variables that are set. Does
> that make sense to clarify?

From my point of view, this would be a sensible thing to document,
although I feel like the grammar is not quite right, because after
"establishes remote session settings for the parameters" my brain
expects a list of parameters rather than a list of parameters and the
corresponding values.  I think it reads better if you change "for the
parameters" to "for various parameters".

</nitpicking>

Revised doc patch attached with various parameters.
Attachment

Re: [HACKERS] [BUGS] Seems bug in postgres_fdw?

From
Robert Haas
Date:
On Mon, Mar 6, 2017 at 9:45 AM, Rader, David <davidr@openscg.com> wrote:
> Revised doc patch attached with various parameters.

Committed.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company