Thread: [HACKERS] simplify sequence test
We maintain a separate test output file sequence_1.out because the log_cnt value can vary if there is a checkpoint happening at the right time. So we have to maintain two files because of a one character difference. I propose the attached patch to restructure the test a bit to avoid this, without loss of test coverage. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Attachment
On 25/01/17 03:48, Peter Eisentraut wrote: > We maintain a separate test output file sequence_1.out because the > log_cnt value can vary if there is a checkpoint happening at the right > time. So we have to maintain two files because of a one character > difference. I propose the attached patch to restructure the test a bit > to avoid this, without loss of test coverage. > +1, looks good. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services
On 1/25/17 5:29 AM, Petr Jelinek wrote: > On 25/01/17 03:48, Peter Eisentraut wrote: >> We maintain a separate test output file sequence_1.out because the >> log_cnt value can vary if there is a checkpoint happening at the right >> time. So we have to maintain two files because of a one character >> difference. I propose the attached patch to restructure the test a bit >> to avoid this, without loss of test coverage. >> > > +1, looks good. committed -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services