Postgres Pro
Downloads
Home   >   mailing lists

Thread: [PATCH] Remove redundant if clause in standbydesc.c

[PATCH] Remove redundant if clause in standbydesc.c

From
Aleksander Alekseev
Date:
Hello.

Very simple small patch - see attachment.

--
Best regards,
Aleksander Alekseev
Attachment

Re: [PATCH] Remove redundant if clause in standbydesc.c

From
Michael Paquier
Date:
On Fri, Sep 23, 2016 at 6:08 PM, Aleksander Alekseev
<a.alekseev@postgrespro.ru> wrote:
> Very simple small patch - see attachment.
        /* not expected, but print something anyway */        else if (msg->id == SHAREDINVALRELMAP_ID)
-            appendStringInfoString(buf, " relmap");
-        else if (msg->id == SHAREDINVALRELMAP_ID)            appendStringInfo(buf, " relmap db %u", msg->rm.dbId);

Looking at inval.c, dbId can be InvalidOid.
-- 
Michael

Re: [PATCH] Remove redundant if clause in standbydesc.c

From
Aleksander Alekseev
Date:
> > Very simple small patch - see attachment.
> 
>          /* not expected, but print something anyway */
>          else if (msg->id == SHAREDINVALRELMAP_ID)
> -            appendStringInfoString(buf, " relmap");
> -        else if (msg->id == SHAREDINVALRELMAP_ID)
>              appendStringInfo(buf, " relmap db %u", msg->rm.dbId);
> 
> Looking at inval.c, dbId can be InvalidOid.

Frankly I'm not very familiar with this part of code. InvalidOid is just
zero. Does it create some problem in this case?

-- 
Best regards,
Aleksander Alekseev

Re: [PATCH] Remove redundant if clause in standbydesc.c

From
Michael Paquier
Date:
On Fri, Sep 23, 2016 at 6:54 PM, Aleksander Alekseev
<a.alekseev@postgrespro.ru> wrote:
>> > Very simple small patch - see attachment.
>>
>>          /* not expected, but print something anyway */
>>          else if (msg->id == SHAREDINVALRELMAP_ID)
>> -            appendStringInfoString(buf, " relmap");
>> -        else if (msg->id == SHAREDINVALRELMAP_ID)
>>              appendStringInfo(buf, " relmap db %u", msg->rm.dbId);
>>
>> Looking at inval.c, dbId can be InvalidOid.
>
> Frankly I'm not very familiar with this part of code. InvalidOid is just
> zero. Does it create some problem in this case?

Not really but my guess is that the two conditions have been left for
this purpose.
-- 
Michael

Re: [PATCH] Remove redundant if clause in standbydesc.c

From
Tom Lane
Date:
Michael Paquier <michael.paquier@gmail.com> writes:
> On Fri, Sep 23, 2016 at 6:54 PM, Aleksander Alekseev
> <a.alekseev@postgrespro.ru> wrote:
>>> Very simple small patch - see attachment.
>>> 
>>>          /* not expected, but print something anyway */
>>>          else if (msg->id == SHAREDINVALRELMAP_ID)
>>> -            appendStringInfoString(buf, " relmap");
>>> -        else if (msg->id == SHAREDINVALRELMAP_ID)
>>>              appendStringInfo(buf, " relmap db %u", msg->rm.dbId);

> Not really but my guess is that the two conditions have been left for
> this purpose.

I think it's a pretty obvious copy-and-pasteo.
        regards, tom lane