Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] Remove redundant if clause in standbydesc.c - Mailing list pgsql-hackers

From Aleksander Alekseev
Subject Re: [PATCH] Remove redundant if clause in standbydesc.c
Date
Msg-id 20160923095431.GD1238@e733
Whole thread Raw
In response to Re: [PATCH] Remove redundant if clause in standbydesc.c  (Michael Paquier <michael.paquier@gmail.com>)
Responses Re: [PATCH] Remove redundant if clause in standbydesc.c  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-hackers
Tree view 
> > Very simple small patch - see attachment.
> 
>          /* not expected, but print something anyway */
>          else if (msg->id == SHAREDINVALRELMAP_ID)
> -            appendStringInfoString(buf, " relmap");
> -        else if (msg->id == SHAREDINVALRELMAP_ID)
>              appendStringInfo(buf, " relmap db %u", msg->rm.dbId);
> 
> Looking at inval.c, dbId can be InvalidOid.

Frankly I'm not very familiar with this part of code. InvalidOid is just
zero. Does it create some problem in this case?

-- 
Best regards,
Aleksander Alekseev

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: [PATCH] Remove redundant if clause in standbydesc.c
Next
From: Amit Kapila
Date:
Subject: Re: [HACKERS] Re: [HACKERS] Re: [HACKERS] Re: [HACKERS] Re: [HACKERS] Re: [HACKERS] Windows service is not starting so there’s message in log: FATAL: "could not create shared memory segment “Global/PostgreSQL.851401618”: Permission denied”