Re: [PATCH] Remove redundant if clause in standbydesc.c - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [PATCH] Remove redundant if clause in standbydesc.c
Date
Msg-id CAB7nPqREvpH6Ex5nKYdkPmkP3iVWW1UHo_1KwsP=kR69OF3=aQ@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Remove redundant if clause in standbydesc.c  (Aleksander Alekseev <a.alekseev@postgrespro.ru>)
Responses Re: [PATCH] Remove redundant if clause in standbydesc.c  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Fri, Sep 23, 2016 at 6:54 PM, Aleksander Alekseev
<a.alekseev@postgrespro.ru> wrote:
>> > Very simple small patch - see attachment.
>>
>>          /* not expected, but print something anyway */
>>          else if (msg->id == SHAREDINVALRELMAP_ID)
>> -            appendStringInfoString(buf, " relmap");
>> -        else if (msg->id == SHAREDINVALRELMAP_ID)
>>              appendStringInfo(buf, " relmap db %u", msg->rm.dbId);
>>
>> Looking at inval.c, dbId can be InvalidOid.
>
> Frankly I'm not very familiar with this part of code. InvalidOid is just
> zero. Does it create some problem in this case?

Not really but my guess is that the two conditions have been left for
this purpose.
-- 
Michael



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Tracking wait event for latches
Next
From: Teodor Sigaev
Date:
Subject: Re: Phrase search distance syntax