Thread: A couple of minor CVS configuration issues
Could we get "objfiles.txt" added to CVSROOT/cvsignore, as suggested here: http://archives.postgresql.org/pgsql-hackers/2008-02/msg01041.php Another thing that's been annoying me for a long time is that the cvsweb server does not show $PostgreSQL$ lines properly in diffs; for example here http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/arrayfuncs.c?r1=1.140&r2=1.140.2.1 the displayed diff in the $PostgreSQL$ line is for the ancestor revision not this one. I recall someone saying that this was because $PostgreSQL$ is not known as a keyword by the anoncvs CVS installation. If that's the case, could we get it fixed please? regards, tom lane
Tom Lane wrote: > Could we get "objfiles.txt" added to CVSROOT/cvsignore, as suggested > here: > http://archives.postgresql.org/pgsql-hackers/2008-02/msg01041.php I'll take a look at this in a day or two. > Another thing that's been annoying me for a long time is that the > cvsweb server does not show $PostgreSQL$ lines properly in diffs; for > example here > > http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/arrayfuncs.c?r1=1.140&r2=1.140.2.1 > > the displayed diff in the $PostgreSQL$ line is for the ancestor > revision not this one. I recall someone saying that this was because > $PostgreSQL$ is not known as a keyword by the anoncvs CVS > installation. If that's the case, could we get it fixed please? The problem is, IIRC, that cvsweb uses rcsdiff to run it's diffs, and there is no way to make it recognize it without manually patching the C code to rcsdiff and do a separate install. That said, I'll add it to my TODO (well, it's been there for a while mentally, just not written down), but it's not going to be a quick-fix. //Magnus
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 - --On Friday, April 11, 2008 19:08:14 -0400 Tom Lane <tgl@sss.pgh.pa.us> wrote: > Could we get "objfiles.txt" added to CVSROOT/cvsignore, as suggested > here: > http://archives.postgresql.org/pgsql-hackers/2008-02/msg01041.php Done, sorry for delay ... - -- Marc G. Fournier Hub.Org Hosting Solutions S.A. (http://www.hub.org) Email . scrappy@hub.org MSN . scrappy@hub.org Yahoo . yscrappy Skype: hub.org ICQ . 7615664 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.8 (FreeBSD) iEYEARECAAYFAkgBg3UACgkQ4QvfyHIvDvO9UACgi0sTNRljpN+MKP2dhuyN7OGY zW0AnA06sb9AZtt3Aco5gpRtxiNHdVjv =J2gw -----END PGP SIGNATURE-----
"Marc G. Fournier" <scrappy@hub.org> writes: > - --On Friday, April 11, 2008 19:08:14 -0400 Tom Lane <tgl@sss.pgh.pa.us> wrote: >> Could we get "objfiles.txt" added to CVSROOT/cvsignore, as suggested >> here: >> http://archives.postgresql.org/pgsql-hackers/2008-02/msg01041.php > Done, sorry for delay ... Thanks, seems to work nicely here. Do you rememeber what was involved in the $PostgreSQL$ business? I thought I remembered you saying that it was only a configuration-file adjustment, but Magnus seems to think it requires hacking the code of cvs ... regards, tom lane
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 - --On Sunday, April 13, 2008 00:01:45 -0400 Tom Lane <tgl@sss.pgh.pa.us> wrote: > Do you rememeber what was involved in the $PostgreSQL$ business? > I thought I remembered you saying that it was only a configuration-file > adjustment, but Magnus seems to think it requires hacking the code > of cvs ... Hrmmm, that's kind of neat ... it looks like an 'off by one' sort of thing ... if you change r1=1.140 to r1=1.139, it now the tag as being 1.138 ... etc ... the diff itself looks fine, just that one line ... same behaviour if you use rcsdiff from the command line ... Just curious, but can someone on a non-FreeBSD box that has a copy of CVS itself try: cd <CVS>/pgsql/src/backend/utils/adt rcsdiff -r1.139 -r1.140.2.1 arrayfuncs.c | less and check the output of the $PostgreSQL lines? Are they 'off by one' for non-FreeBSD boxes too, or is this a FreeBSD/rcsdiff issue ... I've just logged into work, where we have Linux boxes, and its running 5.7 also, so its not an older version ... - -- Marc G. Fournier Hub.Org Hosting Solutions S.A. (http://www.hub.org) Email . scrappy@hub.org MSN . scrappy@hub.org Yahoo . yscrappy Skype: hub.org ICQ . 7615664 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.8 (FreeBSD) iEYEARECAAYFAkgBjKcACgkQ4QvfyHIvDvOKsACfYxNteCHMGzNWg3vd1qHyqBwF eiYAoJ2FsjWIBLRdOf768OHGouG/bezP =Qcn4 -----END PGP SIGNATURE-----