Thread: vcbuild bison check

Attached patch adds a version check for bison when running the vc++
build.

//Magnus <<vcbuild_bison.diff>>

"Magnus Hagander" <mha@sollentuna.net> writes:
> Attached patch adds a version check for bison when running the vc++
> build.

Shouldn't it be looking for 2.1 as well?

            regards, tom lane

> > Attached patch adds a version check for bison when running the vc++
> > build.
>
> Shouldn't it be looking for 2.1 as well?

2.1 is the broken one. It seemd it was fixed in 2.2, but 2.2 isn't
realeased for win32 from what I cna tell.

//Magnus

"Magnus Hagander" <mha@sollentuna.net> writes:
>>> Attached patch adds a version check for bison when running the vc++
>>> build.
>>
>> Shouldn't it be looking for 2.1 as well?

> 2.1 is the broken one.

Exactly.  So we should reject it.

> It seemd it was fixed in 2.2, but 2.2 isn't
> realeased for win32 from what I cna tell.

What's that got to do with rejecting 2.1?

            regards, tom lane

> >>> Attached patch adds a version check for bison when running the
> vc++
> >>> build.
> >>
> >> Shouldn't it be looking for 2.1 as well?
>
> > 2.1 is the broken one.
>
> Exactly.  So we should reject it.

We do. The code as-is *only* accepts 1.875. Thus it rejects 2.1.

//Magnus

Magnus Hagander wrote:
> > >>> Attached patch adds a version check for bison when running the
> > vc++
> > >>> build.
> > >>
> > >> Shouldn't it be looking for 2.1 as well?
> >
> > > 2.1 is the broken one.
> >
> > Exactly.  So we should reject it.
>
> We do. The code as-is *only* accepts 1.875. Thus it rejects 2.1.

I think Tom's point is that we should reject only 2.1.  Isn't that the
only version that fails?

--
  Bruce Momjian   bruce@momjian.us
  EnterpriseDB    http://www.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +