Re: vcbuild bison check - Mailing list pgsql-patches

From Magnus Hagander
Subject Re: vcbuild bison check
Date
Msg-id 6BCB9D8A16AC4241919521715F4D8BCEA3577C@algol.sollentuna.se
Whole thread Raw
In response to Re: vcbuild bison check  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: vcbuild bison check  (Bruce Momjian <bruce@momjian.us>)
List pgsql-patches
> >>> Attached patch adds a version check for bison when running the
> vc++
> >>> build.
> >>
> >> Shouldn't it be looking for 2.1 as well?
>
> > 2.1 is the broken one.
>
> Exactly.  So we should reject it.

We do. The code as-is *only* accepts 1.875. Thus it rejects 2.1.

//Magnus

pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: putting CHECK_FOR_INTERRUPTS in qsort_comparetup()
Next
From: Bruce Momjian
Date:
Subject: Re: vcbuild bison check