Re: [PATCHES] vcbuild bison check - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: [PATCHES] vcbuild bison check
Date
Msg-id 200610041012.k94ACTA29139@momjian.us
Whole thread Raw
In response to Re: [PATCHES] vcbuild bison check  ("Magnus Hagander" <mha@sollentuna.net>)
Responses Re: [PATCHES] vcbuild bison check
List pgsql-hackers
Magnus Hagander wrote:
> > >>> Attached patch adds a version check for bison when running the
> > vc++
> > >>> build.
> > >>
> > >> Shouldn't it be looking for 2.1 as well?
> >
> > > 2.1 is the broken one.
> >
> > Exactly.  So we should reject it.
>
> We do. The code as-is *only* accepts 1.875. Thus it rejects 2.1.

I think Tom's point is that we should reject only 2.1.  Isn't that the
only version that fails?

--
  Bruce Momjian   bruce@momjian.us
  EnterpriseDB    http://www.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

pgsql-hackers by date:

Previous
From: Michael Meskes
Date:
Subject: Re: buildfarm failures in ECPG-Check
Next
From: Bruce Momjian
Date:
Subject: Re: pgindent has been run