Thread: MSVC build broken (again)

The code around errcode is definitly messy. In CVS now, it actually
renames *our* errcode() function to __msvc_errcode, and exports this
from postgres.exe. This is definitly very borken.

The check for _MSC_VER > 1400 won't come true until Microsoft releases
the next verison of Visual Studio - VS2005 is 1400, not >1400.

Attached patch fixes this. Tested on MSVC and on Mingw.

//Magnus

"Magnus Hagander" <mha@sollentuna.net> writes:
> The code around errcode is definitly messy. In CVS now, it actually
> renames *our* errcode() function to __msvc_errcode, and exports this
> from postgres.exe. This is definitly very borken.

Would it be possible to move the whole <crtdefs.h> block into win32.h?
This would cause it to be included after <stdio.h> and friends, which
maybe is too late, but taking it out of c.h would be a lot cleaner.

            regards, tom lane

> > The code around errcode is definitly messy. In CVS now, it actually
> > renames *our* errcode() function to __msvc_errcode, and
> exports this
> > from postgres.exe. This is definitly very borken.
>
> Would it be possible to move the whole <crtdefs.h> block into win32.h?
> This would cause it to be included after <stdio.h> and
> friends, which maybe is too late, but taking it out of c.h
> would be a lot cleaner.

Nope, it needs to go before <stdio.h> and friends, unfortunatly.

//Magnus

"Magnus Hagander" <mha@sollentuna.net> writes:
>> Would it be possible to move the whole <crtdefs.h> block into win32.h?

> Nope, it needs to go before <stdio.h> and friends, unfortunatly.

OK, patch committed as-is then.  The whole thing still looks awfully
icky though, particularly the way pg_config_os.h is included in one
place for WIN32 and a different place everywhere else.

Would it make sense to split win32.h into two files, one that's included
in the normal pg_config_os.h place and one included after the system
includes?

            regards, tom lane