Re: MSVC build broken (again) - Mailing list pgsql-patches

From Tom Lane
Subject Re: MSVC build broken (again)
Date
Msg-id 10793.1159907773@sss.pgh.pa.us
Whole thread Raw
In response to Re: MSVC build broken (again)  ("Magnus Hagander" <mha@sollentuna.net>)
List pgsql-patches
"Magnus Hagander" <mha@sollentuna.net> writes:
>> Would it be possible to move the whole <crtdefs.h> block into win32.h?

> Nope, it needs to go before <stdio.h> and friends, unfortunatly.

OK, patch committed as-is then.  The whole thing still looks awfully
icky though, particularly the way pg_config_os.h is included in one
place for WIN32 and a different place everywhere else.

Would it make sense to split win32.h into two files, one that's included
in the normal pg_config_os.h place and one included after the system
includes?

            regards, tom lane

pgsql-patches by date:

Previous
From: "Magnus Hagander"
Date:
Subject: Re: MSVC build broken (again)
Next
From: Tom Lane
Date:
Subject: Re: vcbuild bison check