Re: [PATCHES] MSVC build broken (again) - Mailing list pgsql-hackers

From Magnus Hagander
Subject Re: [PATCHES] MSVC build broken (again)
Date
Msg-id 6BCB9D8A16AC4241919521715F4D8BCEA0FC1A@algol.sollentuna.se
Whole thread Raw
In response to Re: [PATCHES] MSVC build broken (again)  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [PATCHES] MSVC build broken (again)
List pgsql-hackers
> > The code around errcode is definitly messy. In CVS now, it actually
> > renames *our* errcode() function to __msvc_errcode, and
> exports this
> > from postgres.exe. This is definitly very borken.
>
> Would it be possible to move the whole <crtdefs.h> block into win32.h?
> This would cause it to be included after <stdio.h> and
> friends, which maybe is too late, but taking it out of c.h
> would be a lot cleaner.

Nope, it needs to go before <stdio.h> and friends, unfortunatly.

//Magnus

pgsql-hackers by date:

Previous
From: Zdenek Kotala
Date:
Subject: Re: PG qsort vs. Solaris
Next
From: Zdenek Kotala
Date:
Subject: Re: [PATCHES] Generic Monitoring Framework with DTrace patch