Thread: Re: [HACKERS] psql and readline
Here's the patch I promised over on HACKERS - it alters the implementation of '\e' history tracking for systems that have a readline compatability library without replace_history_entry. I fall back to pushing the query onto the history stack after the \e, rather than replacing it. The patch adds one more place to look for readline headers, and a test for replace_history_entry. I've only included the patch for configure.in - I presume configure in CVS is generated on the central server? (I've got autoconf 2.54 installed, the file in CVS was generated by 2.53 - there are a number of diffs other than those caused by my additions to configure.in) Patrick, does this patch work for you, in your build environment? Ross
Attachment
On Sat, Feb 15, 2003 at 08:29:12PM -0600, Ross J. Reedstrom wrote: > Here's the patch I promised over on HACKERS - it alters the implementation > of '\e' history tracking for systems that have a readline compatability > library without replace_history_entry. I fall back to pushing the query > onto the history stack after the \e, rather than replacing it. > > The patch adds one more place to look for readline headers, and a test > for replace_history_entry. I've only included the patch for configure.in - > I presume configure in CVS is generated on the central server? (I've got > autoconf 2.54 installed, the file in CVS was generated by 2.53 - there are > a number of diffs other than those caused by my additions to configure.in) > > Patrick, does this patch work for you, in your build environment? checking for readline... yes (-ledit -lcurses) ... checking readline/readline.h usability... yes checking readline/readline.h presence... yes checking for readline/readline.h... yes checking readline/history.h usability... yes checking readline/history.h presence... yes checking for readline/history.h... yes ... checking for rl_completion_append_character... yes checking for rl_completion_matches... no checking for rl_filename_completion_function... no checking for replace_history_entry... no and cursor up gets me the previous command, \e edits it, and another cursor up gets me the command as edited, so all OK ! Thank you! Patrick
Your patch has been added to the PostgreSQL unapplied patches list at:
http://momjian.postgresql.org/cgi-bin/pgpatches
I will try to apply it within the next 48 hours.
---------------------------------------------------------------------------
Ross J. Reedstrom wrote:
> Here's the patch I promised over on HACKERS - it alters the implementation
> of '\e' history tracking for systems that have a readline compatability
> library without replace_history_entry. I fall back to pushing the query
> onto the history stack after the \e, rather than replacing it.
>
> The patch adds one more place to look for readline headers, and a test
> for replace_history_entry. I've only included the patch for configure.in -
> I presume configure in CVS is generated on the central server? (I've got
> autoconf 2.54 installed, the file in CVS was generated by 2.53 - there are
> a number of diffs other than those caused by my additions to configure.in)
>
> Patrick, does this patch work for you, in your build environment?
>
> Ross
>
[ Attachment, skipping... ]
--
Bruce Momjian | http://candle.pha.pa.us
pgman@candle.pha.pa.us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
Patch applied. Thanks. --------------------------------------------------------------------------- Ross J. Reedstrom wrote: > Here's the patch I promised over on HACKERS - it alters the implementation > of '\e' history tracking for systems that have a readline compatability > library without replace_history_entry. I fall back to pushing the query > onto the history stack after the \e, rather than replacing it. > > The patch adds one more place to look for readline headers, and a test > for replace_history_entry. I've only included the patch for configure.in - > I presume configure in CVS is generated on the central server? (I've got > autoconf 2.54 installed, the file in CVS was generated by 2.53 - there are > a number of diffs other than those caused by my additions to configure.in) > > Patrick, does this patch work for you, in your build environment? > > Ross > [ Attachment, skipping... ] -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square, Pennsylvania 19073