Re: [HACKERS] psql and readline - Mailing list pgsql-patches

From Patrick Welche
Subject Re: [HACKERS] psql and readline
Date
Msg-id 20030216180450.C4454@quartz.newn.cam.ac.uk
Whole thread Raw
In response to Re: [HACKERS] psql and readline  ("Ross J. Reedstrom" <reedstrm@rice.edu>)
List pgsql-patches
On Sat, Feb 15, 2003 at 08:29:12PM -0600, Ross J. Reedstrom wrote:
> Here's the patch I promised over on HACKERS - it alters the implementation
> of '\e' history tracking for systems that have a readline compatability
> library without replace_history_entry.  I fall back to pushing the query
> onto the history stack after the \e, rather than replacing it.
>
> The patch adds one more place to look for readline headers, and a test
> for replace_history_entry. I've only included the patch for configure.in -
> I presume configure in CVS is generated on the central server? (I've got
> autoconf 2.54 installed, the file in CVS was generated by 2.53 - there are
> a number of diffs other than those caused by my additions to configure.in)
>
> Patrick, does this patch work for you, in your build environment?

checking for readline... yes (-ledit -lcurses)
...
checking readline/readline.h usability... yes
checking readline/readline.h presence... yes
checking for readline/readline.h... yes
checking readline/history.h usability... yes
checking readline/history.h presence... yes
checking for readline/history.h... yes
...
checking for rl_completion_append_character... yes
checking for rl_completion_matches... no
checking for rl_filename_completion_function... no
checking for replace_history_entry... no


and cursor up gets me the previous command, \e edits it, and another
cursor up gets me the command as edited, so all OK !

Thank you!

Patrick

pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: Evaluate arguments of COALESCE and NULLIF only once.
Next
From: "Christopher Kings-Lynne"
Date:
Subject: Non-colliding auto generated names