Thread: ODBC Patch to prevent setting of KSQO on 7.3+ servers
Subject says it all... BTW: Hiroshi, did you get a change to review my UI patch yet? Regards, Dave.
Great. Also, we disabled KSQO in 7.1 so you should check for 7.1, not 7.3. --------------------------------------------------------------------------- Dave Page wrote: > Subject says it all... > > BTW: Hiroshi, did you get a change to review my UI patch yet? > > Regards, Dave. Content-Description: odbc-ksqo.patch [ Attachment, skipping... ] > > ---------------------------(end of broadcast)--------------------------- > TIP 5: Have you checked our extensive FAQ? > > http://www.postgresql.org/users-lounge/docs/faq.html -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 853-3000 + If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup. | Drexel Hill, Pennsylvania 19026
"Dave Page" <dpage@vale-housing.co.uk> writes:
> Subject says it all...
Actually, you might as well suppress sending "set ksqo" in all
PG versions >= 7.1. It's been dead code since then...
regards, tom lane
Updated patch already submitted :-) Regards, Dave. > -----Original Message----- > From: Tom Lane [mailto:tgl@sss.pgh.pa.us] > Sent: 22 June 2002 22:18 > To: Dave Page > Cc: pgsql-odbc@postgresql.org; pgsql-patches@postgresql.org > Subject: Re: [ODBC] ODBC Patch to prevent setting of KSQO on > 7.3+ servers > > > "Dave Page" <dpage@vale-housing.co.uk> writes: > > Subject says it all... > > Actually, you might as well suppress sending "set ksqo" in > all PG versions >= 7.1. It's been dead code since then... > > regards, tom lane > >
Dave Page wrote: > > Ack! Of course you did - it just still accepted the setting until the > other day! > > Update attached... > OK, where's the patch? -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 853-3000 + If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup. | Drexel Hill, Pennsylvania 19026
> -----Original Message----- > From: Hiroshi Inoue [mailto:Inoue@tpf.co.jp] > Sent: 24 June 2002 06:11 > To: Dave Page > Cc: pgsql-odbc@postgresql.org; pgsql-patches@postgresql.org > Subject: Re: [ODBC] ODBC Patch to prevent setting of KSQO on > 7.3+ servers > > > Dave Page wrote: > > > > Subject says it all... > > OK. I would apply it after checking it. > > > BTW: Hiroshi, did you get a change to review my UI patch yet? > > Not so much, sorry. > You edited it using a resource editor ? > #ifdef MULTIBYTE stuff etc seems to be removed. > I've had no time to think how to manage it. Hmm, yes, I used either the Visual Studio 6 or Visual Studio.NET editor (I forget which) - and it took a fair while even that way. I didn't realise there was any #ifdef MULTIBYTE stuff in there & figured that VS was OK considering the header in the file: //Microsoft Developer Studio generated resource script. I can either figure out the differences and manually sort it, or we could get rid of the non-multibyte version (we don't ship it anymore anyway, as we agreed some time ago). Which do you prefer? Regards, Dave.
> -----Original Message----- > From: Bruce Momjian [mailto:pgman@candle.pha.pa.us] > Sent: 23 June 2002 00:35 > To: Dave Page > Cc: pgsql-odbc@postgresql.org; pgsql-patches@postgresql.org > Subject: Re: [ODBC] ODBC Patch to prevent setting of KSQO on > 7.3+ servers > > > Dave Page wrote: > > > > Ack! Of course you did - it just still accepted the setting > until the > > other day! > > > > Update attached... > > > > OK, where's the patch? > Sorry, attached this time. Regards, Dave.
Dave Page wrote:
>
> Subject says it all...
OK. I would apply it after checking it.
> BTW: Hiroshi, did you get a change to review my UI patch yet?
Not so much, sorry.
You edited it using a resource editor ?
#ifdef MULTIBYTE stuff etc seems to be removed.
I've had no time to think how to manage it.
regards,
Hiroshi Inoue
http://w2422.nsk.ne.jp/~inoue/
Ack! Of course you did - it just still accepted the setting until the other day! Update attached... Regards, Dave. > -----Original Message----- > From: Bruce Momjian [mailto:pgman@candle.pha.pa.us] > Sent: 22 June 2002 05:03 > To: Dave Page > Cc: pgsql-odbc@postgresql.org; pgsql-patches@postgresql.org > Subject: Re: [ODBC] ODBC Patch to prevent setting of KSQO on > 7.3+ servers > > > > Great. Also, we disabled KSQO in 7.1 so you should check for > 7.1, not 7.3.
Dave Page wrote:
>
> > > BTW: Hiroshi, did you get a change to review my UI patch yet?
> >
> > Not so much, sorry.
> > You edited it using a resource editor ?
> > #ifdef MULTIBYTE stuff etc seems to be removed.
> > I've had no time to think how to manage it.
>
> Hmm, yes, I used either the Visual Studio 6 or Visual Studio.NET editor
> (I forget which) - and it took a fair while even that way. I didn't
> realise there was any #ifdef MULTIBYTE stuff in there & figured that VS
> was OK considering the header in the file:
>
> //Microsoft Developer Studio generated resource script.
>
> I can either figure out the differences and manually sort it, or we
> could get rid of the non-multibyte version (we don't ship it anymore
> anyway, as we agreed some time ago).
>
> Which do you prefer?
Sorry for the late answer.
According to Eiji Tokuya, we had better adopt the
multibyte version of resource if we would only ship
with the multibyte version of driver.
regards,
Hiroshi Inoue
http://w2422.nsk.ne.jp/~inoue/