Thread: Broken API specification for walrcv_receive

I noticed thanks to a buildfarm warning that replication/walreceiver.h
now declares the walrcv_receive hook as

typedef int (*walrcv_receive_type) (char **buffer, int *wait_fd);

This is flat out wrong, isn't it?  wait_fd needs to be of type pgsocket,
which is a different width from "int" on Windows.
        regards, tom lane

On Fri, Apr 15, 2016 at 4:28 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> I noticed thanks to a buildfarm warning that replication/walreceiver.h
> now declares the walrcv_receive hook as
>
> typedef int (*walrcv_receive_type) (char **buffer, int *wait_fd);
>
> This is flat out wrong, isn't it?  wait_fd needs to be of type pgsocket,
> which is a different width from "int" on Windows.

Right, I see.  Thanks for fixing that.

-- 
Thomas Munro
http://www.enterprisedb.com