Broken API specification for walrcv_receive - Mailing list pgsql-hackers

From Tom Lane
Subject Broken API specification for walrcv_receive
Date
Msg-id 30372.1460651323@sss.pgh.pa.us
Whole thread Raw
Responses Re: Broken API specification for walrcv_receive  (Thomas Munro <thomas.munro@enterprisedb.com>)
List pgsql-hackers
I noticed thanks to a buildfarm warning that replication/walreceiver.h
now declares the walrcv_receive hook as

typedef int (*walrcv_receive_type) (char **buffer, int *wait_fd);

This is flat out wrong, isn't it?  wait_fd needs to be of type pgsocket,
which is a different width from "int" on Windows.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Suspicious behaviour on applying XLOG_HEAP2_VISIBLE.
Next
From: Jim Nasby
Date:
Subject: Re: Refactor pg_dump as a library?