Re: Broken API specification for walrcv_receive - Mailing list pgsql-hackers

From Thomas Munro
Subject Re: Broken API specification for walrcv_receive
Date
Msg-id CAEepm=3SrkRm8fw2VM2=QC4OdNW8LyzN2=yECmQ_Kff_X=JNyg@mail.gmail.com
Whole thread Raw
In response to Broken API specification for walrcv_receive  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Fri, Apr 15, 2016 at 4:28 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> I noticed thanks to a buildfarm warning that replication/walreceiver.h
> now declares the walrcv_receive hook as
>
> typedef int (*walrcv_receive_type) (char **buffer, int *wait_fd);
>
> This is flat out wrong, isn't it?  wait_fd needs to be of type pgsocket,
> which is a different width from "int" on Windows.

Right, I see.  Thanks for fixing that.

-- 
Thomas Munro
http://www.enterprisedb.com



pgsql-hackers by date:

Previous
From: Alexander Korotkov
Date:
Subject: Re: Move PinBuffer and UnpinBuffer to atomics
Next
From: Peter Geoghegan
Date:
Subject: Obsolete comment within fmgr.c