Thread: Unneeded NULL-pointer check in FreeSpaceMapTruncateRel

Hi all,

In the category of nitpicky-code-style-issues, FreeSpaceMapTruncateRel
is doing a NULL-pointer check for something that has been dereferenced
on all the code paths leading to this check.
(Yes, that's not interesting for common humans, Coverity sees things
based on correctness).

Regards,
--
Michael

Hi,

On 2015-06-30 21:53:07 +0900, Michael Paquier wrote:
> In the category of nitpicky-code-style-issues, FreeSpaceMapTruncateRel
> is doing a NULL-pointer check for something that has been dereferenced
> on all the code paths leading to this check.
> (Yes, that's not interesting for common humans, Coverity sees things
> based on correctness).

Can you, in the future, batch these together into one thread, perhaps
with one message below an introductory one for each patch? Unless
they'll get applied immediately it'll be hard to follow the different
threads.

Greetings,

Andres Freund

On Tue, Jun 30, 2015 at 9:57 PM, Andres Freund <andres@anarazel.de> wrote:
> On 2015-06-30 21:53:07 +0900, Michael Paquier wrote:
>> In the category of nitpicky-code-style-issues, FreeSpaceMapTruncateRel
>> is doing a NULL-pointer check for something that has been dereferenced
>> on all the code paths leading to this check.
>> (Yes, that's not interesting for common humans, Coverity sees things
>> based on correctness).
>
> Can you, in the future, batch these together into one thread, perhaps
> with one message below an introductory one for each patch? Unless
> they'll get applied immediately it'll be hard to follow the different
> threads.

I'll try.
-- 
Michael