Re: Unneeded NULL-pointer check in FreeSpaceMapTruncateRel - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Unneeded NULL-pointer check in FreeSpaceMapTruncateRel
Date
Msg-id CAB7nPqS89bRiP+az_kGR3tpPqwgP=0RZ58ZZBs0eTTBW-Aygmw@mail.gmail.com
Whole thread Raw
In response to Re: Unneeded NULL-pointer check in FreeSpaceMapTruncateRel  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
On Tue, Jun 30, 2015 at 9:57 PM, Andres Freund <andres@anarazel.de> wrote:
> On 2015-06-30 21:53:07 +0900, Michael Paquier wrote:
>> In the category of nitpicky-code-style-issues, FreeSpaceMapTruncateRel
>> is doing a NULL-pointer check for something that has been dereferenced
>> on all the code paths leading to this check.
>> (Yes, that's not interesting for common humans, Coverity sees things
>> based on correctness).
>
> Can you, in the future, batch these together into one thread, perhaps
> with one message below an introductory one for each patch? Unless
> they'll get applied immediately it'll be hard to follow the different
> threads.

I'll try.
-- 
Michael



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Expending the use of xlog_internal.h's macros
Next
From: Fujii Masao
Date:
Subject: Re: pg_rewind failure by file deletion in source server