Re: Unneeded NULL-pointer check in FreeSpaceMapTruncateRel - Mailing list pgsql-hackers

From Andres Freund
Subject Re: Unneeded NULL-pointer check in FreeSpaceMapTruncateRel
Date
Msg-id 20150630125726.GU30708@awork2.anarazel.de
Whole thread Raw
In response to Unneeded NULL-pointer check in FreeSpaceMapTruncateRel  (Michael Paquier <michael.paquier@gmail.com>)
Responses Re: Unneeded NULL-pointer check in FreeSpaceMapTruncateRel  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-hackers
Hi,

On 2015-06-30 21:53:07 +0900, Michael Paquier wrote:
> In the category of nitpicky-code-style-issues, FreeSpaceMapTruncateRel
> is doing a NULL-pointer check for something that has been dereferenced
> on all the code paths leading to this check.
> (Yes, that's not interesting for common humans, Coverity sees things
> based on correctness).

Can you, in the future, batch these together into one thread, perhaps
with one message below an introductory one for each patch? Unless
they'll get applied immediately it'll be hard to follow the different
threads.

Greetings,

Andres Freund



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Missing checks on return value of timestamp2tm in datetime.c
Next
From: Pavel Stehule
Date:
Subject: Re: Exposing PG_VERSION_NUM in pg_config