Thread: Tab completion for CREATE SEQUENCE
While reviewing the seqam patches, I noticed that psql has tab completion for ALTER SEQUENCE, but not for CREATE SEQUENCE. The attached trivial patch fixes that. -- Vik Fearing +33 6 46 75 15 36 http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Support
Attachment
On Tue, 16 Jun 2015 at 00:52 Vik Fearing <vik@2ndquadrant.fr> wrote:
While reviewing the seqam patches, I noticed that psql has tab
completion for ALTER SEQUENCE, but not for CREATE SEQUENCE.
The attached trivial patch fixes that.
Hi Vik,
I'm doing an initial review of this patch."RESTART", "SET SCHEMA", "OWNER TO", and "RENAME TO" are not valid completions for CREATE SEQUENCE. It looks like these have been blindly copy-pasted from ALTER SEQUENCE. Likewise, the valid completion "START [WITH]" is missing.
"CREATE TEMP[ORARY] SEQUENCE" is not supported, and I think it probably should be. I think that the patch could be improved with support for the TEMP form fairly easily.Apart from the above points, the new completions worked as advertised.
Docs: none needed.
Tests: we don't currently have any test coverage for psql tab completion.
I'm marking this "Waiting on Author". Once the problems have been corrected, it should be ready for a committer.
Cheers,
BJ
On 2015-06-19 06:41:19 +0000, Brendan Jurd wrote: > I'm marking this "Waiting on Author". Once the problems have been > corrected, it should be ready for a committer. Vik, are you going to update the patch?
On Tue, Jul 7, 2015 at 9:14 PM, Andres Freund <andres@anarazel.de> wrote: > On 2015-06-19 06:41:19 +0000, Brendan Jurd wrote: >> I'm marking this "Waiting on Author". Once the problems have been >> corrected, it should be ready for a committer. > > Vik, are you going to update the patch? Seeing no activity on this thread and as it would be a waste not to do it, I completed the patch as attached. The following things are done: - Fixed code indentation - Removal of "RESTART", "SET SCHEMA", "OWNER TO", and "RENAME TO" in CREATE SEQUENCE - Added "START WITH". - Added TEMP/TEMPORARY in the set of keywords tracked. I am switching at the same time this patch as "Ready for committer". Regards, -- Michael
Attachment
On Mon, Aug 3, 2015 at 2:17 AM, Michael Paquier <michael.paquier@gmail.com> wrote: > On Tue, Jul 7, 2015 at 9:14 PM, Andres Freund <andres@anarazel.de> wrote: >> On 2015-06-19 06:41:19 +0000, Brendan Jurd wrote: >>> I'm marking this "Waiting on Author". Once the problems have been >>> corrected, it should be ready for a committer. >> >> Vik, are you going to update the patch? > > Seeing no activity on this thread and as it would be a waste not to do > it, I completed the patch as attached. The following things are done: > - Fixed code indentation > - Removal of "RESTART", "SET SCHEMA", "OWNER TO", and "RENAME TO" in > CREATE SEQUENCE > - Added "START WITH". > - Added TEMP/TEMPORARY in the set of keywords tracked. > I am switching at the same time this patch as "Ready for committer". You didn't remove RESTART, so I did that. And this needed some more parentheses to make my compiler happy. Committed with those changes. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
On 08/04/2015 06:30 PM, Robert Haas wrote: > On Mon, Aug 3, 2015 at 2:17 AM, Michael Paquier > <michael.paquier@gmail.com> wrote: >> On Tue, Jul 7, 2015 at 9:14 PM, Andres Freund <andres@anarazel.de> wrote: >>> On 2015-06-19 06:41:19 +0000, Brendan Jurd wrote: >>>> I'm marking this "Waiting on Author". Once the problems have been >>>> corrected, it should be ready for a committer. >>> >>> Vik, are you going to update the patch? >> >> Seeing no activity on this thread and as it would be a waste not to do >> it, I completed the patch as attached. The following things are done: >> - Fixed code indentation >> - Removal of "RESTART", "SET SCHEMA", "OWNER TO", and "RENAME TO" in >> CREATE SEQUENCE >> - Added "START WITH". >> - Added TEMP/TEMPORARY in the set of keywords tracked. >> I am switching at the same time this patch as "Ready for committer". > > You didn't remove RESTART, so I did that. And this needed some more > parentheses to make my compiler happy. > > Committed with those changes. Thank you, Brendan, Michael, and Robert for taking care of this while I was away. -- Vik Fearing +33 6 46 75 15 36 http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Support
On Wed, Aug 12, 2015 at 9:22 AM, Vik Fearing <vik@2ndquadrant.fr> wrote: > Thank you, Brendan, Michael, and Robert for taking care of this while I > was away. Thanks for the patch! -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company