Thread: Should extension--unpackaged-$ver.sql's \echo use FROM unpackaged;?
Hi, Fujii noticed that I'd used \echo Use "CREATE EXTENSION pg_buffercache" to load this file. \quit in an extension upgrade script. That's obviously wrong, because it should say ALTER EXTENSION. The reason it's that way is that I copied the line from the unpackaged--1.0.sql file. I noticed all unpackaged--$version transition files miss the "FROM unpackaged" in that echo. I guess that's just a oversight which we should correct? Or is there some rationale behind it? Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training & Services
On Thu, Jul 3, 2014 at 4:26 AM, Andres Freund <andres@2ndquadrant.com> wrote: > Hi, > > Fujii noticed that I'd used > \echo Use "CREATE EXTENSION pg_buffercache" to load this file. \quit > in an extension upgrade script. That's obviously wrong, because it > should say ALTER EXTENSION. The reason it's that way is that I copied > the line from the unpackaged--1.0.sql file. > I noticed all unpackaged--$version transition files miss the "FROM > unpackaged" in that echo. > I guess that's just a oversight which we should correct? Maybe for user-friendness. But I think that's not so important fix enough to backpatch. Regards, -- Fujii Masao
On Thu, Jul 3, 2014 at 9:03 AM, Fujii Masao <masao.fujii@gmail.com> wrote: > On Thu, Jul 3, 2014 at 4:26 AM, Andres Freund <andres@2ndquadrant.com> wrote: >> Hi, >> Fujii noticed that I'd used >> \echo Use "CREATE EXTENSION pg_buffercache" to load this file. \quit >> in an extension upgrade script. That's obviously wrong, because it >> should say ALTER EXTENSION. The reason it's that way is that I copied >> the line from the unpackaged--1.0.sql file. >> I noticed all unpackaged--$version transition files miss the "FROM >> unpackaged" in that echo. >> I guess that's just a oversight which we should correct? > > Maybe for user-friendness. But I think that's not so important fix enough > to backpatch. Seems like a clear mistake to me. +1 for fixing it and back-patching. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
On 2014-07-06 16:58:33 -0400, Robert Haas wrote: > On Thu, Jul 3, 2014 at 9:03 AM, Fujii Masao <masao.fujii@gmail.com> wrote: > > On Thu, Jul 3, 2014 at 4:26 AM, Andres Freund <andres@2ndquadrant.com> wrote: > >> Hi, > >> Fujii noticed that I'd used > >> \echo Use "CREATE EXTENSION pg_buffercache" to load this file. \quit > >> in an extension upgrade script. That's obviously wrong, because it > >> should say ALTER EXTENSION. The reason it's that way is that I copied > >> the line from the unpackaged--1.0.sql file. > >> I noticed all unpackaged--$version transition files miss the "FROM > >> unpackaged" in that echo. > >> I guess that's just a oversight which we should correct? > > > > Maybe for user-friendness. But I think that's not so important fix enough > > to backpatch. > > Seems like a clear mistake to me. +1 for fixing it and back-patching. I think so as well - and I now have a patch for it. Fujii, do you mind if I backpatch 6f9e39bc9993c1 to 9.1, 9.2 and 9.3 for you? Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training & Services