Re: Should extension--unpackaged-$ver.sql's \echo use FROM unpackaged;? - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: Should extension--unpackaged-$ver.sql's \echo use FROM unpackaged;?
Date
Msg-id CAHGQGwGSwUKWT0Hg0kQJsiQ_LJY4hrB-SC8onrLG-P+EwmhehQ@mail.gmail.com
Whole thread Raw
In response to Should extension--unpackaged-$ver.sql's \echo use FROM unpackaged;?  (Andres Freund <andres@2ndquadrant.com>)
Responses Re: Should extension--unpackaged-$ver.sql's \echo use FROM unpackaged;?  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
On Thu, Jul 3, 2014 at 4:26 AM, Andres Freund <andres@2ndquadrant.com> wrote:
> Hi,
>
> Fujii noticed that I'd used
> \echo Use "CREATE EXTENSION pg_buffercache" to load this file. \quit
> in an extension upgrade script. That's obviously wrong, because it
> should say ALTER EXTENSION. The reason it's that way is that I copied
> the line from the unpackaged--1.0.sql file.
> I noticed all unpackaged--$version transition files miss the "FROM
> unpackaged" in that echo.
> I guess that's just a oversight which we should correct?

Maybe for user-friendness. But I think that's not so important fix enough
to backpatch.

Regards,

-- 
Fujii Masao



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: gaussian distribution pgbench
Next
From: Fujii Masao
Date:
Subject: Re: docs: additional subsection for page-level locks in explicit-locking section