Thread: Bug fix for 7.4?
I just fixed a bug in ecpglib that caused it to misbehave for all
internal array/vector types. They were treated like the external ones.
So ecpg expected them to be listed as '{...}' which surely failed.
However, this bug fix involves more code changes than I like to just
commit into 7.4 at this point of the release. So the fixes are so far
just committed to HEAD. On the other hand I don't like to release 7.4
with this know bug.
The only solution I see is someone else looking over the patch resp.
testing it. It worked well with my test suite, but then this may not
catch all side effects.
Michael
--
Michael Meskes
Email: Michael at Fam-Meskes dot De
ICQ: 179140304, AIM/Yahoo: michaelmeskes, Jabber: meskes@jabber.org
Go SF 49ers! Go Rhein Fire! Use Debian GNU/Linux! Use PostgreSQL!
Yep. Send patch to patches list and/or have someone who is using this
functionality test it.
---------------------------------------------------------------------------
Michael Meskes wrote:
> I just fixed a bug in ecpglib that caused it to misbehave for all
> internal array/vector types. They were treated like the external ones.
> So ecpg expected them to be listed as '{...}' which surely failed.
>
> However, this bug fix involves more code changes than I like to just
> commit into 7.4 at this point of the release. So the fixes are so far
> just committed to HEAD. On the other hand I don't like to release 7.4
> with this know bug.
>
> The only solution I see is someone else looking over the patch resp.
> testing it. It worked well with my test suite, but then this may not
> catch all side effects.
>
> Michael
> --
> Michael Meskes
> Email: Michael at Fam-Meskes dot De
> ICQ: 179140304, AIM/Yahoo: michaelmeskes, Jabber: meskes@jabber.org
> Go SF 49ers! Go Rhein Fire! Use Debian GNU/Linux! Use PostgreSQL!
>
> ---------------------------(end of broadcast)---------------------------
> TIP 8: explain analyze is your friend
>
-- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610)
359-1001+ If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square,
Pennsylvania19073
Michael Meskes <meskes@postgresql.org> writes:
> I just fixed a bug in ecpglib that caused it to misbehave for all
> internal array/vector types. They were treated like the external ones.
> So ecpg expected them to be listed as '{...}' which surely failed.
> However, this bug fix involves more code changes than I like to just
> commit into 7.4 at this point of the release. So the fixes are so far
> just committed to HEAD. On the other hand I don't like to release 7.4
> with this know bug.
> The only solution I see is someone else looking over the patch resp.
> testing it. It worked well with my test suite, but then this may not
> catch all side effects.
I looked over it, and the only part that seems odd is that you seem to
have removed the type info caching behavior in execute.c. Is that
intended? It looks like ECPGis_type_an_array() will now issue a query
on every call for a non-built-in type, which seems rather a large loss.
Also, if cache_head ever becomes non-null then it stops trusting its
internal knowledge as well, which seems worse.
regards, tom lane
On Mon, Nov 10, 2003 at 10:50:30AM -0500, Tom Lane wrote: > I looked over it, and the only part that seems odd is that you seem to > have removed the type info caching behavior in execute.c. Is that > intended? It looks like ECPGis_type_an_array() will now issue a query Well actually no. I removed it for testing reasons but didn't re-add. > on every call for a non-built-in type, which seems rather a large loss. > Also, if cache_head ever becomes non-null then it stops trusting its > internal knowledge as well, which seems worse. I re-added it. Memo to /me: Just testing it is not enough. Better to look over the code again after a night of sleep. Thanks a lot. Michael -- Michael Meskes Email: Michael at Fam-Meskes dot De ICQ: 179140304, AIM/Yahoo: michaelmeskes, Jabber: meskes@jabber.org Go SF 49ers! Go Rhein Fire! Use Debian GNU/Linux! Use PostgreSQL!