Re: Bug fix for 7.4? - Mailing list pgsql-hackers

From Michael Meskes
Subject Re: Bug fix for 7.4?
Date
Msg-id 20031110203056.GA9568@feivel.fam-meskes.de
Whole thread Raw
In response to Re: Bug fix for 7.4?  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Mon, Nov 10, 2003 at 10:50:30AM -0500, Tom Lane wrote:
> I looked over it, and the only part that seems odd is that you seem to
> have removed the type info caching behavior in execute.c.  Is that
> intended?  It looks like ECPGis_type_an_array() will now issue a query

Well actually no. I removed it for testing reasons but didn't re-add.

> on every call for a non-built-in type, which seems rather a large loss.
> Also, if cache_head ever becomes non-null then it stops trusting its
> internal knowledge as well, which seems worse.

I re-added it. 

Memo to /me: Just testing it is not enough. Better to look over the code
again after a night of sleep.

Thanks a lot.

Michael
-- 
Michael Meskes
Email: Michael at Fam-Meskes dot De
ICQ: 179140304, AIM/Yahoo: michaelmeskes, Jabber: meskes@jabber.org
Go SF 49ers! Go Rhein Fire! Use Debian GNU/Linux! Use PostgreSQL!


pgsql-hackers by date:

Previous
From: "Marc G. Fournier"
Date:
Subject: Re: [7.3.x] function does not exist ... ?
Next
From: Bruce Momjian
Date:
Subject: Re: Experimental patch for inter-page delay in VACUUM