Thread: pgsql-server/src pl/plpgsql/src/pl_comp.c pl/p ...

CVSROOT:    /cvsroot
Module name:    pgsql-server
Changes by:    momjian@postgresql.org    02/09/11 20:24:10

Modified files:
    src/pl/plpgsql/src: pl_comp.c plpgsql.h scan.l
Added files:
    src/test/regress/sql: plpgsql-nsp-testing.sql

Log message:
    > Sean Chittenden <sean@chittenden.org> writes:
    >
    >>::sigh:: Is it me or does it look like all
    >>of pl/pgsql is schema un-aware (ie, all of the declarations).  -sc
    >
    >
    > Yeah.  The group of routines parse_word, parse_dblword, etc that are
    > called by the lexer certainly all need work.  There are some
    > definitional issues to think about, too --- plpgsql presently relies on
    > the number of names to give it some idea of what to look for, and those
    > rules are probably all toast now.  Please come up with a sketch of what
    > you think the behavior should be before you start hacking code.

    Attached is a diff -c format proposal to fix this. I've also attached a short
    test script. Seems to work OK and passes all regression tests.

    Here's a breakdown of how I understand plpgsql's "Special word rules" -- I
    think it illustrates the behavior reasonably well. New functions added by this
    patch are plpgsql_parse_tripwordtype and plpgsql_parse_dblwordrowtype:

    Joe Conway

momjian@postgresql.org (Bruce Momjian - CVS) writes:
> Added files:
>     src/test/regress/sql: plpgsql-nsp-testing.sql

What is this file?  If it is a regression test, why is there no
corresponding expected/ file, nor entries in the schedule files?

            regards, tom lane

Tom Lane wrote:
> momjian@postgresql.org (Bruce Momjian - CVS) writes:
>
>>Added files:
>>    src/test/regress/sql: plpgsql-nsp-testing.sql
>
>
> What is this file?  If it is a regression test, why is there no
> corresponding expected/ file, nor entries in the schedule files?
>

I'm sorry -- I never meant that to be applied to CVS. I should have been more
clear that it was only sent as an aid to the patch reviewer -- that's why it
wasn't in "diff -c" format.

But, if you think it is warranted to have a test for this let me know and I'll
add it to the existing plpgsql test.

Joe

File removed.  Thanks.

---------------------------------------------------------------------------

Tom Lane wrote:
> momjian@postgresql.org (Bruce Momjian - CVS) writes:
> > Added files:
> >     src/test/regress/sql: plpgsql-nsp-testing.sql
>
> What is this file?  If it is a regression test, why is there no
> corresponding expected/ file, nor entries in the schedule files?
>
>             regards, tom lane
>
> ---------------------------(end of broadcast)---------------------------
> TIP 3: if posting/reading through Usenet, please send an appropriate
> subscribe-nomail command to majordomo@postgresql.org so that your
> message can get through to the mailing list cleanly
>

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073