Thread: Fix for RM1318 [pgadmin4]
Hi,
PFA attached patch for issue RM1318.--
Harshal Dhumal
Software Engineer
Attachment
On Mon, Jun 13, 2016 at 7:25 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote: > Hi, > > PFA attached patch for issue RM1318. > > > Issue fixed: Added help buttons on backup, restore, maintenance, user > management dialogs. Thanks - I've committed this as-is, however the following issues should also be fixed: - The help for the User Manager dialogue cannot be used because the dialogue is modal. - There's no help button on the Preferences dialogue. It should also be made non-modal so the user can actually use the help once it's displayed. Thanks. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Hi,
PFA patch for issue RM1318 with remaining bug fixes.On Mon, Jun 13, 2016 at 8:49 PM, Dave Page <dpage@pgadmin.org> wrote:
On Mon, Jun 13, 2016 at 7:25 AM, Harshal Dhumal
<harshal.dhumal@enterprisedb.com> wrote:
> Hi,
>
> PFA attached patch for issue RM1318.
>
>
> Issue fixed: Added help buttons on backup, restore, maintenance, user
> management dialogs.
Thanks - I've committed this as-is, however the following issues
should also be fixed:
- The help for the User Manager dialogue cannot be used because the
dialogue is modal.
Changed user dialog to non modal from modal dialog.
- There's no help button on the Preferences dialogue. It should also
be made non-modal so the user can actually use the help once it's
displayed.
Added missing help button and also changed dialog to non modal.
Thanks.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Attachment
Thanks, applied. On Mon, Jun 13, 2016 at 7:20 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote: > Hi, > > PFA patch for issue RM1318 with remaining bug fixes. > > > On Mon, Jun 13, 2016 at 8:49 PM, Dave Page <dpage@pgadmin.org> wrote: >> >> On Mon, Jun 13, 2016 at 7:25 AM, Harshal Dhumal >> <harshal.dhumal@enterprisedb.com> wrote: >> > Hi, >> > >> > PFA attached patch for issue RM1318. >> > >> > >> > Issue fixed: Added help buttons on backup, restore, maintenance, user >> > management dialogs. >> >> Thanks - I've committed this as-is, however the following issues >> should also be fixed: >> >> - The help for the User Manager dialogue cannot be used because the >> dialogue is modal. > > > Changed user dialog to non modal from modal dialog. > >> >> >> - There's no help button on the Preferences dialogue. It should also >> be made non-modal so the user can actually use the help once it's >> displayed. > > Added missing help button and also changed dialog to non modal. > > >> >> >> Thanks. >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company