Postgres Pro
Downloads
Home   >   mailing lists

Re: Fix for RM1318 [pgadmin4] - Mailing list pgadmin-hackers

From Harshal Dhumal
Subject Re: Fix for RM1318 [pgadmin4]
Date
Msg-id CAFiP3vy6zuoQeZkjCci7jbuaouuz6U6t+V=47pRZJC-PhJAwSQ@mail.gmail.com
Whole thread Raw
In response to Re: Fix for RM1318 [pgadmin4]  (Dave Page <dpage@pgadmin.org>)
Responses Re: Fix for RM1318 [pgadmin4]  (Dave Page <dpage@pgadmin.org>)
List pgadmin-hackers
Tree view
Hi,

PFA patch for issue RM1318 with remaining bug fixes.


On Mon, Jun 13, 2016 at 8:49 PM, Dave Page <dpage@pgadmin.org> wrote:
On Mon, Jun 13, 2016 at 7:25 AM, Harshal Dhumal
<harshal.dhumal@enterprisedb.com> wrote:
> Hi,
>
> PFA attached patch for issue RM1318.
>
>
> Issue fixed: Added help buttons on backup, restore, maintenance, user
> management dialogs.

Thanks - I've committed this as-is, however the following issues
should also be fixed:

- The help for the User Manager dialogue cannot be used because the
dialogue is modal.
 
Changed user dialog to non modal from modal dialog.
 

- There's no help button on the Preferences dialogue. It should also
be made non-modal so the user can actually use the help once it's
displayed.
Added missing help button and also changed dialog to non modal.

 

Thanks.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment

pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: Re: pgadmin4 slow with large tables compared to pgadmin3
Next
From: Harshal Dhumal
Date:
Subject: Fix for issue RM1348 [pgadmin4]