Re: Fix for RM1318 [pgadmin4] - Mailing list pgadmin-hackers

From Dave Page
Subject Re: Fix for RM1318 [pgadmin4]
Date
Msg-id CA+OCxoxM8G2kuoONOr-PvsYoeu9wJPTkMNsutcwJF8_6XdurwA@mail.gmail.com
Whole thread Raw
In response to Fix for RM1318 [pgadmin4]  (Harshal Dhumal <harshal.dhumal@enterprisedb.com>)
Responses Re: Fix for RM1318 [pgadmin4]  (Harshal Dhumal <harshal.dhumal@enterprisedb.com>)
List pgadmin-hackers
On Mon, Jun 13, 2016 at 7:25 AM, Harshal Dhumal
<harshal.dhumal@enterprisedb.com> wrote:
> Hi,
>
> PFA attached patch for issue RM1318.
>
>
> Issue fixed: Added help buttons on backup, restore, maintenance, user
> management dialogs.

Thanks - I've committed this as-is, however the following issues
should also be fixed:

- The help for the User Manager dialogue cannot be used because the
dialogue is modal.

- There's no help button on the Preferences dialogue. It should also
be made non-modal so the user can actually use the help once it's
displayed.

Thanks.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: pgAdmin 4 commit: Help buttons for various dialogues.
Next
From: Dave Page
Date:
Subject: pgAdmin 4 commit: Fix comment removal for various nodes. Fixes #1331