Thread: pgAdmin III commit: Pull keywords dynamically from PostgreSQL headers

pgAdmin III commit: Pull keywords dynamically from PostgreSQL headers

From
Magnus Hagander
Date:
Pull keywords dynamically from PostgreSQL headers

Instead of copying header information into files in pgadmin,
pull the data from PostgreSQL header files.

The keywords for EnterpriseDB and Greenplum databases are still
hardcoded in pgAdmin.

Branch
------
master

Details
-------
http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=161afbde23dd05976de02d759c0bf06023a175c2

Modified Files
--------------
pgadmin/db/keywords.c             |  521 +++++++------------------------------
pgadmin/include/parser/keywords.h |  448 +-------------------------------
pgadmin/utils/misc.cpp            |   16 +-
3 files changed, 111 insertions(+), 874 deletions(-)


Re: pgAdmin III commit: Pull keywords dynamically from PostgreSQL headers

From
Ashesh Vashi
Date:
Hi Magnus/Dave,

This check-in has added one compilation error.
The following line introduce an error in file 'pgadmin/db/keywords.c'
#include <server/parser/gram.h>
#include <server/parser/kwlist.h>


Because - these header files does not always find under `pg_config --includedir` folder, but can be found under `pg_config --pkgincludedir`.

Please find the patch to resolve the issue. This applies on both master and REL-1_12_PATCHES branch.

--
Thanks & Regards,


Ashesh Vashi
EnterpriseDB INDIA:
Enterprise PostgreSQL Company

 

http://www.linkedin.com/in/asheshvashi



On Thu, Dec 30, 2010 at 1:47 PM, Magnus Hagander <magnus@hagander.net> wrote:
Pull keywords dynamically from PostgreSQL headers

Instead of copying header information into files in pgadmin,
pull the data from PostgreSQL header files.

The keywords for EnterpriseDB and Greenplum databases are still
hardcoded in pgAdmin.

Branch
------
master

Details
-------
http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=161afbde23dd05976de02d759c0bf06023a175c2

Modified Files
--------------
pgadmin/db/keywords.c             |  521 +++++++------------------------------
pgadmin/include/parser/keywords.h |  448 +-------------------------------
pgadmin/utils/misc.cpp            |   16 +-
3 files changed, 111 insertions(+), 874 deletions(-)


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Attachment

Re: pgAdmin III commit: Pull keywords dynamically from PostgreSQL headers

From
Magnus Hagander
Date:
On Tue, Jan 4, 2011 at 18:46, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Magnus/Dave,

This check-in has added one compilation error.
The following line introduce an error in file 'pgadmin/db/keywords.c'
#include <server/parser/gram.h>
#include <server/parser/kwlist.h>


Because - these header files does not always find under `pg_config --includedir` folder, but can be found under `pg_config --pkgincludedir`.

Please find the patch to resolve the issue. This applies on both master and REL-1_12_PATCHES branch.


Looks good in general, but do we actually need to put it on 1.12? The keyword build changes were only applied to master, so unless we actually *need* it on the back branch, I don't think we should put it there.  Is it needed for something else as well?



--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

Re: pgAdmin III commit: Pull keywords dynamically from PostgreSQL headers

From
Ashesh Vashi
Date:


On Wed, Jan 5, 2011 at 12:37 AM, Magnus Hagander <magnus@hagander.net> wrote:
On Tue, Jan 4, 2011 at 18:46, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Magnus/Dave,

This check-in has added one compilation error.
The following line introduce an error in file 'pgadmin/db/keywords.c'
#include <server/parser/gram.h>
#include <server/parser/kwlist.h>


Because - these header files does not always find under `pg_config --includedir` folder, but can be found under `pg_config --pkgincludedir`.

Please find the patch to resolve the issue. This applies on both master and REL-1_12_PATCHES branch.


Looks good in general, but do we actually need to put it on 1.12? The keyword build changes were only applied to master, so unless we actually *need* it on the back branch, I don't think we should put it there.  Is it needed for something else as well?
You're right.
This patch should only be applied on master.

--
Thanks & Regards,


Ashesh Vashi
EnterpriseDB INDIA:
Enterprise PostgreSQL Company

 

http://www.linkedin.com/in/asheshvashi





--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

Re: pgAdmin III commit: Pull keywords dynamically from PostgreSQL headers

From
Magnus Hagander
Date:
On Wed, Jan 5, 2011 at 06:05, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:


On Wed, Jan 5, 2011 at 12:37 AM, Magnus Hagander <magnus@hagander.net> wrote:
On Tue, Jan 4, 2011 at 18:46, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Magnus/Dave,

This check-in has added one compilation error.
The following line introduce an error in file 'pgadmin/db/keywords.c'
#include <server/parser/gram.h>
#include <server/parser/kwlist.h>


Because - these header files does not always find under `pg_config --includedir` folder, but can be found under `pg_config --pkgincludedir`.

Please find the patch to resolve the issue. This applies on both master and REL-1_12_PATCHES branch.


Looks good in general, but do we actually need to put it on 1.12? The keyword build changes were only applied to master, so unless we actually *need* it on the back branch, I don't think we should put it there.  Is it needed for something else as well?
You're right.
This patch should only be applied on master.

 Thanks, confirmed and applied.


--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

Re: pgAdmin III commit: Pull keywords dynamically from PostgreSQL headers

From
Jasmin Dizdarevic
Date:
Hi, 

since this patch is applied, i can't build pgAdmin. %pgdir%\include\server\parser doesn't contain a gram.h file. 
What I'm doing wrong?

Ty
Jasmin

2011/1/5 Magnus Hagander <magnus@hagander.net>
On Wed, Jan 5, 2011 at 06:05, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:


On Wed, Jan 5, 2011 at 12:37 AM, Magnus Hagander <magnus@hagander.net> wrote:
On Tue, Jan 4, 2011 at 18:46, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Magnus/Dave,

This check-in has added one compilation error.
The following line introduce an error in file 'pgadmin/db/keywords.c'
#include <server/parser/gram.h>
#include <server/parser/kwlist.h>


Because - these header files does not always find under `pg_config --includedir` folder, but can be found under `pg_config --pkgincludedir`.

Please find the patch to resolve the issue. This applies on both master and REL-1_12_PATCHES branch.


Looks good in general, but do we actually need to put it on 1.12? The keyword build changes were only applied to master, so unless we actually *need* it on the back branch, I don't think we should put it there.  Is it needed for something else as well?
You're right.
This patch should only be applied on master.

 Thanks, confirmed and applied.

Re: pgAdmin III commit: Pull keywords dynamically from PostgreSQL headers

From
Magnus Hagander
Date:
What version of PostgreSQL are you using? And how was it installed?

//Magnus

On Thu, Jan 6, 2011 at 17:34, Jasmin Dizdarevic
<jasmin.dizdarevic@gmail.com> wrote:
> Hi,
> since this patch is applied, i can't build
> pgAdmin. %pgdir%\include\server\parser doesn't contain a gram.h file.
> What I'm doing wrong?
> Ty
> Jasmin
>
> 2011/1/5 Magnus Hagander <magnus@hagander.net>
>>
>> On Wed, Jan 5, 2011 at 06:05, Ashesh Vashi <ashesh.vashi@enterprisedb.com>
>> wrote:
>>>
>>>
>>> On Wed, Jan 5, 2011 at 12:37 AM, Magnus Hagander <magnus@hagander.net>
>>> wrote:
>>>>
>>>> On Tue, Jan 4, 2011 at 18:46, Ashesh Vashi
>>>> <ashesh.vashi@enterprisedb.com> wrote:
>>>>>
>>>>> Hi Magnus/Dave,
>>>>>
>>>>> This check-in has added one compilation error.
>>>>> The following line introduce an error in file 'pgadmin/db/keywords.c'
>>>>> #include <server/parser/gram.h>
>>>>> #include <server/parser/kwlist.h>
>>>>>
>>>>> Because - these header files does not always find under `pg_config
>>>>> --includedir` folder, but can be found under `pg_config --pkgincludedir`.
>>>>>
>>>>> Please find the patch to resolve the issue. This applies on both master
>>>>> and REL-1_12_PATCHES branch.
>>>>>
>>>>
>>>> Looks good in general, but do we actually need to put it on 1.12? The
>>>> keyword build changes were only applied to master, so unless we actually
>>>> *need* it on the back branch, I don't think we should put it there.  Is it
>>>> needed for something else as well?
>>>
>>> You're right.
>>> This patch should only be applied on master.
>>
>>  Thanks, confirmed and applied.

Re: pgAdmin III commit: Pull keywords dynamically from PostgreSQL headers

From
Ashesh Vashi
Date:
Do you have %PGDIR%/include/postgresql/server/parser directory which contains gram.h?

--
Thanks & Regards,


Ashesh Vashi
EnterpriseDB INDIA:
Enterprise PostgreSQL Company

 

http://www.linkedin.com/in/asheshvashi



On Thu, Jan 6, 2011 at 10:04 PM, Jasmin Dizdarevic <jasmin.dizdarevic@gmail.com> wrote:
Hi, 

since this patch is applied, i can't build pgAdmin. %pgdir%\include\server\parser doesn't contain a gram.h file. 
What I'm doing wrong?

Ty
Jasmin

2011/1/5 Magnus Hagander <magnus@hagander.net>

On Wed, Jan 5, 2011 at 06:05, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:


On Wed, Jan 5, 2011 at 12:37 AM, Magnus Hagander <magnus@hagander.net> wrote:
On Tue, Jan 4, 2011 at 18:46, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Magnus/Dave,

This check-in has added one compilation error.
The following line introduce an error in file 'pgadmin/db/keywords.c'
#include <server/parser/gram.h>
#include <server/parser/kwlist.h>


Because - these header files does not always find under `pg_config --includedir` folder, but can be found under `pg_config --pkgincludedir`.

Please find the patch to resolve the issue. This applies on both master and REL-1_12_PATCHES branch.


Looks good in general, but do we actually need to put it on 1.12? The keyword build changes were only applied to master, so unless we actually *need* it on the back branch, I don't think we should put it there.  Is it needed for something else as well?
You're right.
This patch should only be applied on master.

 Thanks, confirmed and applied.


Re: pgAdmin III commit: Pull keywords dynamically from PostgreSQL headers

From
Jasmin Dizdarevic
Date:
unpacked zip. version is 8.4
should i build it from source?

2011/1/6 Ashesh Vashi <ashesh.vashi@enterprisedb.com>
how did you install it?


--
Thanks & Regards,


Ashesh Vashi
EnterpriseDB INDIA:
Enterprise PostgreSQL Company

 

http://www.linkedin.com/in/asheshvashi



On Thu, Jan 6, 2011 at 10:15 PM, Jasmin Dizdarevic <jasmin.dizdarevic@gmail.com> wrote:
the directory is there, but no gram.h.

2011/1/6 Ashesh Vashi <ashesh.vashi@enterprisedb.com>

Do you have %PGDIR%/include/postgresql/server/parser directory which contains gram.h?


--
Thanks & Regards,


Ashesh Vashi
EnterpriseDB INDIA:
Enterprise PostgreSQL Company

 

http://www.linkedin.com/in/asheshvashi



On Thu, Jan 6, 2011 at 10:04 PM, Jasmin Dizdarevic <jasmin.dizdarevic@gmail.com> wrote:
Hi, 

since this patch is applied, i can't build pgAdmin. %pgdir%\include\server\parser doesn't contain a gram.h file. 
What I'm doing wrong?

Ty
Jasmin

2011/1/5 Magnus Hagander <magnus@hagander.net>

On Wed, Jan 5, 2011 at 06:05, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:


On Wed, Jan 5, 2011 at 12:37 AM, Magnus Hagander <magnus@hagander.net> wrote:
On Tue, Jan 4, 2011 at 18:46, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Magnus/Dave,

This check-in has added one compilation error.
The following line introduce an error in file 'pgadmin/db/keywords.c'
#include <server/parser/gram.h>
#include <server/parser/kwlist.h>


Because - these header files does not always find under `pg_config --includedir` folder, but can be found under `pg_config --pkgincludedir`.

Please find the patch to resolve the issue. This applies on both master and REL-1_12_PATCHES branch.


Looks good in general, but do we actually need to put it on 1.12? The keyword build changes were only applied to master, so unless we actually *need* it on the back branch, I don't think we should put it there.  Is it needed for something else as well?
You're right.
This patch should only be applied on master.

 Thanks, confirmed and applied.





Re: pgAdmin III commit: Pull keywords dynamically from PostgreSQL headers

From
Ashesh Vashi
Date:
From where did you get it?

--
Thanks & Regards,


Ashesh Vashi
EnterpriseDB INDIA:
Enterprise PostgreSQL Company

 

http://www.linkedin.com/in/asheshvashi



On Thu, Jan 6, 2011 at 10:20 PM, Jasmin Dizdarevic <jasmin.dizdarevic@gmail.com> wrote:
unpacked zip. version is 8.4
should i build it from source?


2011/1/6 Ashesh Vashi <ashesh.vashi@enterprisedb.com>
how did you install it?


--
Thanks & Regards,


Ashesh Vashi
EnterpriseDB INDIA:
Enterprise PostgreSQL Company

 

http://www.linkedin.com/in/asheshvashi



On Thu, Jan 6, 2011 at 10:15 PM, Jasmin Dizdarevic <jasmin.dizdarevic@gmail.com> wrote:
the directory is there, but no gram.h.

2011/1/6 Ashesh Vashi <ashesh.vashi@enterprisedb.com>

Do you have %PGDIR%/include/postgresql/server/parser directory which contains gram.h?


--
Thanks & Regards,


Ashesh Vashi
EnterpriseDB INDIA:
Enterprise PostgreSQL Company

 

http://www.linkedin.com/in/asheshvashi



On Thu, Jan 6, 2011 at 10:04 PM, Jasmin Dizdarevic <jasmin.dizdarevic@gmail.com> wrote:
Hi, 

since this patch is applied, i can't build pgAdmin. %pgdir%\include\server\parser doesn't contain a gram.h file. 
What I'm doing wrong?

Ty
Jasmin

2011/1/5 Magnus Hagander <magnus@hagander.net>

On Wed, Jan 5, 2011 at 06:05, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:


On Wed, Jan 5, 2011 at 12:37 AM, Magnus Hagander <magnus@hagander.net> wrote:
On Tue, Jan 4, 2011 at 18:46, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Magnus/Dave,

This check-in has added one compilation error.
The following line introduce an error in file 'pgadmin/db/keywords.c'
#include <server/parser/gram.h>
#include <server/parser/kwlist.h>


Because - these header files does not always find under `pg_config --includedir` folder, but can be found under `pg_config --pkgincludedir`.

Please find the patch to resolve the issue. This applies on both master and REL-1_12_PATCHES branch.


Looks good in general, but do we actually need to put it on 1.12? The keyword build changes were only applied to master, so unless we actually *need* it on the back branch, I don't think we should put it there.  Is it needed for something else as well?
You're right.
This patch should only be applied on master.

 Thanks, confirmed and applied.






Re: pgAdmin III commit: Pull keywords dynamically from PostgreSQL headers

From
Jasmin Dizdarevic
Date:
From http://www.enterprisedb.com/products/pgbindownload.do two weeks ago.


2011/1/6 Ashesh Vashi <ashesh.vashi@enterprisedb.com>
From where did you get it?


--
Thanks & Regards,


Ashesh Vashi
EnterpriseDB INDIA:
Enterprise PostgreSQL Company

 

http://www.linkedin.com/in/asheshvashi



On Thu, Jan 6, 2011 at 10:20 PM, Jasmin Dizdarevic <jasmin.dizdarevic@gmail.com> wrote:
unpacked zip. version is 8.4
should i build it from source?


2011/1/6 Ashesh Vashi <ashesh.vashi@enterprisedb.com>
how did you install it?


--
Thanks & Regards,


Ashesh Vashi
EnterpriseDB INDIA:
Enterprise PostgreSQL Company

 

http://www.linkedin.com/in/asheshvashi



On Thu, Jan 6, 2011 at 10:15 PM, Jasmin Dizdarevic <jasmin.dizdarevic@gmail.com> wrote:
the directory is there, but no gram.h.

2011/1/6 Ashesh Vashi <ashesh.vashi@enterprisedb.com>

Do you have %PGDIR%/include/postgresql/server/parser directory which contains gram.h?


--
Thanks & Regards,


Ashesh Vashi
EnterpriseDB INDIA:
Enterprise PostgreSQL Company

 

http://www.linkedin.com/in/asheshvashi



On Thu, Jan 6, 2011 at 10:04 PM, Jasmin Dizdarevic <jasmin.dizdarevic@gmail.com> wrote:
Hi, 

since this patch is applied, i can't build pgAdmin. %pgdir%\include\server\parser doesn't contain a gram.h file. 
What I'm doing wrong?

Ty
Jasmin

2011/1/5 Magnus Hagander <magnus@hagander.net>

On Wed, Jan 5, 2011 at 06:05, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:


On Wed, Jan 5, 2011 at 12:37 AM, Magnus Hagander <magnus@hagander.net> wrote:
On Tue, Jan 4, 2011 at 18:46, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Magnus/Dave,

This check-in has added one compilation error.
The following line introduce an error in file 'pgadmin/db/keywords.c'
#include <server/parser/gram.h>
#include <server/parser/kwlist.h>


Because - these header files does not always find under `pg_config --includedir` folder, but can be found under `pg_config --pkgincludedir`.

Please find the patch to resolve the issue. This applies on both master and REL-1_12_PATCHES branch.


Looks good in general, but do we actually need to put it on 1.12? The keyword build changes were only applied to master, so unless we actually *need* it on the back branch, I don't think we should put it there.  Is it needed for something else as well?
You're right.
This patch should only be applied on master.

 Thanks, confirmed and applied.







Re: pgAdmin III commit: Pull keywords dynamically from PostgreSQL headers

From
Ashesh Vashi
Date:
I just downloaded one to cross check.
And as I suspect, they include those headers.

Please download it again (if possible).

--
Thanks & Regards,


Ashesh Vashi
EnterpriseDB INDIA:
Enterprise PostgreSQL Company

 

http://www.linkedin.com/in/asheshvashi



On Thu, Jan 6, 2011 at 10:25 PM, Jasmin Dizdarevic <jasmin.dizdarevic@gmail.com> wrote:
From http://www.enterprisedb.com/products/pgbindownload.do two weeks ago.


2011/1/6 Ashesh Vashi <ashesh.vashi@enterprisedb.com>
From where did you get it?


--
Thanks & Regards,


Ashesh Vashi
EnterpriseDB INDIA:
Enterprise PostgreSQL Company

 

http://www.linkedin.com/in/asheshvashi



On Thu, Jan 6, 2011 at 10:20 PM, Jasmin Dizdarevic <jasmin.dizdarevic@gmail.com> wrote:
unpacked zip. version is 8.4
should i build it from source?


2011/1/6 Ashesh Vashi <ashesh.vashi@enterprisedb.com>
how did you install it?


--
Thanks & Regards,


Ashesh Vashi
EnterpriseDB INDIA:
Enterprise PostgreSQL Company

 

http://www.linkedin.com/in/asheshvashi



On Thu, Jan 6, 2011 at 10:15 PM, Jasmin Dizdarevic <jasmin.dizdarevic@gmail.com> wrote:
the directory is there, but no gram.h.

2011/1/6 Ashesh Vashi <ashesh.vashi@enterprisedb.com>

Do you have %PGDIR%/include/postgresql/server/parser directory which contains gram.h?


--
Thanks & Regards,


Ashesh Vashi
EnterpriseDB INDIA:
Enterprise PostgreSQL Company

 

http://www.linkedin.com/in/asheshvashi



On Thu, Jan 6, 2011 at 10:04 PM, Jasmin Dizdarevic <jasmin.dizdarevic@gmail.com> wrote:
Hi, 

since this patch is applied, i can't build pgAdmin. %pgdir%\include\server\parser doesn't contain a gram.h file. 
What I'm doing wrong?

Ty
Jasmin

2011/1/5 Magnus Hagander <magnus@hagander.net>

On Wed, Jan 5, 2011 at 06:05, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:


On Wed, Jan 5, 2011 at 12:37 AM, Magnus Hagander <magnus@hagander.net> wrote:
On Tue, Jan 4, 2011 at 18:46, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Magnus/Dave,

This check-in has added one compilation error.
The following line introduce an error in file 'pgadmin/db/keywords.c'
#include <server/parser/gram.h>
#include <server/parser/kwlist.h>


Because - these header files does not always find under `pg_config --includedir` folder, but can be found under `pg_config --pkgincludedir`.

Please find the patch to resolve the issue. This applies on both master and REL-1_12_PATCHES branch.


Looks good in general, but do we actually need to put it on 1.12? The keyword build changes were only applied to master, so unless we actually *need* it on the back branch, I don't think we should put it there.  Is it needed for something else as well?
You're right.
This patch should only be applied on master.

 Thanks, confirmed and applied.








Fwd: pgAdmin III commit: Pull keywords dynamically from PostgreSQL headers

From
Jasmin Dizdarevic
Date:


---------- Forwarded message ----------
From: Jasmin Dizdarevic <jasmin.dizdarevic@gmail.com>
Date: 2011/1/6
Subject: Re: [pgadmin-hackers] pgAdmin III commit: Pull keywords dynamically from PostgreSQL headers
To: Ashesh Vashi <ashesh.vashi@enterprisedb.com>


OK, I've noticed now, that the file is only included in the linux binaries version. Maybe the pgadmin3/INSTALL File should be modified to make this clear - for beginners.

I had downloaded the windows version before.

Thank you for your help.


2011/1/6 Ashesh Vashi <ashesh.vashi@enterprisedb.com>
I just downloaded one to cross check.
And as I suspect, they include those headers.

Please download it again (if possible).


--
Thanks & Regards,


Ashesh Vashi
EnterpriseDB INDIA:
Enterprise PostgreSQL Company

 

http://www.linkedin.com/in/asheshvashi



On Thu, Jan 6, 2011 at 10:25 PM, Jasmin Dizdarevic <jasmin.dizdarevic@gmail.com> wrote:
From http://www.enterprisedb.com/products/pgbindownload.do two weeks ago.


2011/1/6 Ashesh Vashi <ashesh.vashi@enterprisedb.com>
From where did you get it?


--
Thanks & Regards,


Ashesh Vashi
EnterpriseDB INDIA:
Enterprise PostgreSQL Company

 

http://www.linkedin.com/in/asheshvashi



On Thu, Jan 6, 2011 at 10:20 PM, Jasmin Dizdarevic <jasmin.dizdarevic@gmail.com> wrote:
unpacked zip. version is 8.4
should i build it from source?


2011/1/6 Ashesh Vashi <ashesh.vashi@enterprisedb.com>
how did you install it?


--
Thanks & Regards,


Ashesh Vashi
EnterpriseDB INDIA:
Enterprise PostgreSQL Company

 

http://www.linkedin.com/in/asheshvashi



On Thu, Jan 6, 2011 at 10:15 PM, Jasmin Dizdarevic <jasmin.dizdarevic@gmail.com> wrote:
the directory is there, but no gram.h.

2011/1/6 Ashesh Vashi <ashesh.vashi@enterprisedb.com>

Do you have %PGDIR%/include/postgresql/server/parser directory which contains gram.h?


--
Thanks & Regards,


Ashesh Vashi
EnterpriseDB INDIA:
Enterprise PostgreSQL Company

 

http://www.linkedin.com/in/asheshvashi



On Thu, Jan 6, 2011 at 10:04 PM, Jasmin Dizdarevic <jasmin.dizdarevic@gmail.com> wrote:
Hi, 

since this patch is applied, i can't build pgAdmin. %pgdir%\include\server\parser doesn't contain a gram.h file. 
What I'm doing wrong?

Ty
Jasmin

2011/1/5 Magnus Hagander <magnus@hagander.net>

On Wed, Jan 5, 2011 at 06:05, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:


On Wed, Jan 5, 2011 at 12:37 AM, Magnus Hagander <magnus@hagander.net> wrote:
On Tue, Jan 4, 2011 at 18:46, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Magnus/Dave,

This check-in has added one compilation error.
The following line introduce an error in file 'pgadmin/db/keywords.c'
#include <server/parser/gram.h>
#include <server/parser/kwlist.h>


Because - these header files does not always find under `pg_config --includedir` folder, but can be found under `pg_config --pkgincludedir`.

Please find the patch to resolve the issue. This applies on both master and REL-1_12_PATCHES branch.


Looks good in general, but do we actually need to put it on 1.12? The keyword build changes were only applied to master, so unless we actually *need* it on the back branch, I don't think we should put it there.  Is it needed for something else as well?
You're right.
This patch should only be applied on master.

 Thanks, confirmed and applied.










Re: pgAdmin III commit: Pull keywords dynamically from PostgreSQL headers

From
Magnus Hagander
Date:
Hmm. If it's included in he linux installer but not the windows one, that looks like a bug in the windows installer to me. Is it an optoinal feature that can be turned on and off, or is it supposed to always be installed? (question directed at the installer guys, not you Jasmin! :P)

//Magnus


On Thu, Jan 6, 2011 at 18:19, Jasmin Dizdarevic <jasmin.dizdarevic@gmail.com> wrote:


---------- Forwarded message ----------
From: Jasmin Dizdarevic <jasmin.dizdarevic@gmail.com>
Date: 2011/1/6
Subject: Re: [pgadmin-hackers] pgAdmin III commit: Pull keywords dynamically from PostgreSQL headers
To: Ashesh Vashi <ashesh.vashi@enterprisedb.com>


OK, I've noticed now, that the file is only included in the linux binaries version. Maybe the pgadmin3/INSTALL File should be modified to make this clear - for beginners.

I had downloaded the windows version before.

Thank you for your help.


2011/1/6 Ashesh Vashi <ashesh.vashi@enterprisedb.com>
I just downloaded one to cross check.
And as I suspect, they include those headers.

Please download it again (if possible).


--
Thanks & Regards,


Ashesh Vashi
EnterpriseDB INDIA:
Enterprise PostgreSQL Company

 

http://www.linkedin.com/in/asheshvashi



On Thu, Jan 6, 2011 at 10:25 PM, Jasmin Dizdarevic <jasmin.dizdarevic@gmail.com> wrote:
From http://www.enterprisedb.com/products/pgbindownload.do two weeks ago.


2011/1/6 Ashesh Vashi <ashesh.vashi@enterprisedb.com>
From where did you get it?


--
Thanks & Regards,


Ashesh Vashi
EnterpriseDB INDIA:
Enterprise PostgreSQL Company

 

http://www.linkedin.com/in/asheshvashi



On Thu, Jan 6, 2011 at 10:20 PM, Jasmin Dizdarevic <jasmin.dizdarevic@gmail.com> wrote:
unpacked zip. version is 8.4
should i build it from source?


2011/1/6 Ashesh Vashi <ashesh.vashi@enterprisedb.com>
how did you install it?


--
Thanks & Regards,


Ashesh Vashi
EnterpriseDB INDIA:
Enterprise PostgreSQL Company

 

http://www.linkedin.com/in/asheshvashi



On Thu, Jan 6, 2011 at 10:15 PM, Jasmin Dizdarevic <jasmin.dizdarevic@gmail.com> wrote:
the directory is there, but no gram.h.

2011/1/6 Ashesh Vashi <ashesh.vashi@enterprisedb.com>

Do you have %PGDIR%/include/postgresql/server/parser directory which contains gram.h?


--
Thanks & Regards,


Ashesh Vashi
EnterpriseDB INDIA:
Enterprise PostgreSQL Company

 

http://www.linkedin.com/in/asheshvashi



On Thu, Jan 6, 2011 at 10:04 PM, Jasmin Dizdarevic <jasmin.dizdarevic@gmail.com> wrote:
Hi, 

since this patch is applied, i can't build pgAdmin. %pgdir%\include\server\parser doesn't contain a gram.h file. 
What I'm doing wrong?

Ty
Jasmin

2011/1/5 Magnus Hagander <magnus@hagander.net>

On Wed, Jan 5, 2011 at 06:05, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:


On Wed, Jan 5, 2011 at 12:37 AM, Magnus Hagander <magnus@hagander.net> wrote:
On Tue, Jan 4, 2011 at 18:46, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Magnus/Dave,

This check-in has added one compilation error.
The following line introduce an error in file 'pgadmin/db/keywords.c'
#include <server/parser/gram.h>
#include <server/parser/kwlist.h>


Because - these header files does not always find under `pg_config --includedir` folder, but can be found under `pg_config --pkgincludedir`.

Please find the patch to resolve the issue. This applies on both master and REL-1_12_PATCHES branch.


Looks good in general, but do we actually need to put it on 1.12? The keyword build changes were only applied to master, so unless we actually *need* it on the back branch, I don't think we should put it there.  Is it needed for something else as well?
You're right.
This patch should only be applied on master.

 Thanks, confirmed and applied.













--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

Re: pgAdmin III commit: Pull keywords dynamically from PostgreSQL headers

From
Jasmin Dizdarevic
Date:
+++ Magnus. 

I solved it with simply copy gram.h to %pgdir%\include\server\parser\

2011/1/6 Magnus Hagander <magnus@hagander.net>
Hmm. If it's included in he linux installer but not the windows one, that looks like a bug in the windows installer to me. Is it an optoinal feature that can be turned on and off, or is it supposed to always be installed? (question directed at the installer guys, not you Jasmin! :P)

//Magnus


On Thu, Jan 6, 2011 at 18:19, Jasmin Dizdarevic <jasmin.dizdarevic@gmail.com> wrote:


---------- Forwarded message ----------
From: Jasmin Dizdarevic <jasmin.dizdarevic@gmail.com>
Date: 2011/1/6
Subject: Re: [pgadmin-hackers] pgAdmin III commit: Pull keywords dynamically from PostgreSQL headers
To: Ashesh Vashi <ashesh.vashi@enterprisedb.com>


OK, I've noticed now, that the file is only included in the linux binaries version. Maybe the pgadmin3/INSTALL File should be modified to make this clear - for beginners.

I had downloaded the windows version before.

Thank you for your help.


2011/1/6 Ashesh Vashi <ashesh.vashi@enterprisedb.com>
I just downloaded one to cross check.
And as I suspect, they include those headers.

Please download it again (if possible).


--
Thanks & Regards,


Ashesh Vashi
EnterpriseDB INDIA:
Enterprise PostgreSQL Company

 

http://www.linkedin.com/in/asheshvashi



On Thu, Jan 6, 2011 at 10:25 PM, Jasmin Dizdarevic <jasmin.dizdarevic@gmail.com> wrote:
From http://www.enterprisedb.com/products/pgbindownload.do two weeks ago.


2011/1/6 Ashesh Vashi <ashesh.vashi@enterprisedb.com>
From where did you get it?


--
Thanks & Regards,


Ashesh Vashi
EnterpriseDB INDIA:
Enterprise PostgreSQL Company

 

http://www.linkedin.com/in/asheshvashi



On Thu, Jan 6, 2011 at 10:20 PM, Jasmin Dizdarevic <jasmin.dizdarevic@gmail.com> wrote:
unpacked zip. version is 8.4
should i build it from source?


2011/1/6 Ashesh Vashi <ashesh.vashi@enterprisedb.com>
how did you install it?


--
Thanks & Regards,


Ashesh Vashi
EnterpriseDB INDIA:
Enterprise PostgreSQL Company

 

http://www.linkedin.com/in/asheshvashi



On Thu, Jan 6, 2011 at 10:15 PM, Jasmin Dizdarevic <jasmin.dizdarevic@gmail.com> wrote:
the directory is there, but no gram.h.

2011/1/6 Ashesh Vashi <ashesh.vashi@enterprisedb.com>

Do you have %PGDIR%/include/postgresql/server/parser directory which contains gram.h?


--
Thanks & Regards,


Ashesh Vashi
EnterpriseDB INDIA:
Enterprise PostgreSQL Company

 

http://www.linkedin.com/in/asheshvashi



On Thu, Jan 6, 2011 at 10:04 PM, Jasmin Dizdarevic <jasmin.dizdarevic@gmail.com> wrote:
Hi, 

since this patch is applied, i can't build pgAdmin. %pgdir%\include\server\parser doesn't contain a gram.h file. 
What I'm doing wrong?

Ty
Jasmin

2011/1/5 Magnus Hagander <magnus@hagander.net>

On Wed, Jan 5, 2011 at 06:05, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:


On Wed, Jan 5, 2011 at 12:37 AM, Magnus Hagander <magnus@hagander.net> wrote:
On Tue, Jan 4, 2011 at 18:46, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Magnus/Dave,

This check-in has added one compilation error.
The following line introduce an error in file 'pgadmin/db/keywords.c'
#include <server/parser/gram.h>
#include <server/parser/kwlist.h>


Because - these header files does not always find under `pg_config --includedir` folder, but can be found under `pg_config --pkgincludedir`.

Please find the patch to resolve the issue. This applies on both master and REL-1_12_PATCHES branch.


Looks good in general, but do we actually need to put it on 1.12? The keyword build changes were only applied to master, so unless we actually *need* it on the back branch, I don't think we should put it there.  Is it needed for something else as well?
You're right.
This patch should only be applied on master.

 Thanks, confirmed and applied.













--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

Re: pgAdmin III commit: Pull keywords dynamically from PostgreSQL headers

From
Dave Page
Date:
The installer bundles everything that is copied into the installation staging directory by the VC++ build scripts. If that file is missing, then Postgres' build system most likely didn't copy it into our staging area. I wonder who wrote that? :-p

On Thu, Jan 6, 2011 at 5:50 PM, Magnus Hagander <magnus@hagander.net> wrote:
Hmm. If it's included in he linux installer but not the windows one, that looks like a bug in the windows installer to me. Is it an optoinal feature that can be turned on and off, or is it supposed to always be installed? (question directed at the installer guys, not you Jasmin! :P)

//Magnus


On Thu, Jan 6, 2011 at 18:19, Jasmin Dizdarevic <jasmin.dizdarevic@gmail.com> wrote:


---------- Forwarded message ----------
From: Jasmin Dizdarevic <jasmin.dizdarevic@gmail.com>
Date: 2011/1/6
Subject: Re: [pgadmin-hackers] pgAdmin III commit: Pull keywords dynamically from PostgreSQL headers
To: Ashesh Vashi <ashesh.vashi@enterprisedb.com>


OK, I've noticed now, that the file is only included in the linux binaries version. Maybe the pgadmin3/INSTALL File should be modified to make this clear - for beginners.

I had downloaded the windows version before.

Thank you for your help.


2011/1/6 Ashesh Vashi <ashesh.vashi@enterprisedb.com>
I just downloaded one to cross check.
And as I suspect, they include those headers.

Please download it again (if possible).


--
Thanks & Regards,


Ashesh Vashi
EnterpriseDB INDIA:
Enterprise PostgreSQL Company

 

http://www.linkedin.com/in/asheshvashi



On Thu, Jan 6, 2011 at 10:25 PM, Jasmin Dizdarevic <jasmin.dizdarevic@gmail.com> wrote:
From http://www.enterprisedb.com/products/pgbindownload.do two weeks ago.


2011/1/6 Ashesh Vashi <ashesh.vashi@enterprisedb.com>
From where did you get it?


--
Thanks & Regards,


Ashesh Vashi
EnterpriseDB INDIA:
Enterprise PostgreSQL Company

 

http://www.linkedin.com/in/asheshvashi



On Thu, Jan 6, 2011 at 10:20 PM, Jasmin Dizdarevic <jasmin.dizdarevic@gmail.com> wrote:
unpacked zip. version is 8.4
should i build it from source?


2011/1/6 Ashesh Vashi <ashesh.vashi@enterprisedb.com>
how did you install it?


--
Thanks & Regards,


Ashesh Vashi
EnterpriseDB INDIA:
Enterprise PostgreSQL Company

 

http://www.linkedin.com/in/asheshvashi



On Thu, Jan 6, 2011 at 10:15 PM, Jasmin Dizdarevic <jasmin.dizdarevic@gmail.com> wrote:
the directory is there, but no gram.h.

2011/1/6 Ashesh Vashi <ashesh.vashi@enterprisedb.com>

Do you have %PGDIR%/include/postgresql/server/parser directory which contains gram.h?


--
Thanks & Regards,


Ashesh Vashi
EnterpriseDB INDIA:
Enterprise PostgreSQL Company

 

http://www.linkedin.com/in/asheshvashi



On Thu, Jan 6, 2011 at 10:04 PM, Jasmin Dizdarevic <jasmin.dizdarevic@gmail.com> wrote:
Hi, 

since this patch is applied, i can't build pgAdmin. %pgdir%\include\server\parser doesn't contain a gram.h file. 
What I'm doing wrong?

Ty
Jasmin

2011/1/5 Magnus Hagander <magnus@hagander.net>

On Wed, Jan 5, 2011 at 06:05, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:


On Wed, Jan 5, 2011 at 12:37 AM, Magnus Hagander <magnus@hagander.net> wrote:
On Tue, Jan 4, 2011 at 18:46, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Magnus/Dave,

This check-in has added one compilation error.
The following line introduce an error in file 'pgadmin/db/keywords.c'
#include <server/parser/gram.h>
#include <server/parser/kwlist.h>


Because - these header files does not always find under `pg_config --includedir` folder, but can be found under `pg_config --pkgincludedir`.

Please find the patch to resolve the issue. This applies on both master and REL-1_12_PATCHES branch.


Looks good in general, but do we actually need to put it on 1.12? The keyword build changes were only applied to master, so unless we actually *need* it on the back branch, I don't think we should put it there.  Is it needed for something else as well?
You're right.
This patch should only be applied on master.

 Thanks, confirmed and applied.













--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: pgAdmin III commit: Pull keywords dynamically from PostgreSQL headers

From
Magnus Hagander
Date:
Clearly someone quite useless...

I've applied a patch to the postgresql build system to install gram.h - feel free to give it a whirl to make sure it comes through all the way into the installer.

//Magnus

On Thu, Jan 6, 2011 at 19:24, Dave Page <dpage@pgadmin.org> wrote:
The installer bundles everything that is copied into the installation staging directory by the VC++ build scripts. If that file is missing, then Postgres' build system most likely didn't copy it into our staging area. I wonder who wrote that? :-p


On Thu, Jan 6, 2011 at 5:50 PM, Magnus Hagander <magnus@hagander.net> wrote:
Hmm. If it's included in he linux installer but not the windows one, that looks like a bug in the windows installer to me. Is it an optoinal feature that can be turned on and off, or is it supposed to always be installed? (question directed at the installer guys, not you Jasmin! :P)

//Magnus


On Thu, Jan 6, 2011 at 18:19, Jasmin Dizdarevic <jasmin.dizdarevic@gmail.com> wrote:


---------- Forwarded message ----------
From: Jasmin Dizdarevic <jasmin.dizdarevic@gmail.com>
Date: 2011/1/6
Subject: Re: [pgadmin-hackers] pgAdmin III commit: Pull keywords dynamically from PostgreSQL headers
To: Ashesh Vashi <ashesh.vashi@enterprisedb.com>


OK, I've noticed now, that the file is only included in the linux binaries version. Maybe the pgadmin3/INSTALL File should be modified to make this clear - for beginners.

I had downloaded the windows version before.

Thank you for your help.


2011/1/6 Ashesh Vashi <ashesh.vashi@enterprisedb.com>
I just downloaded one to cross check.
And as I suspect, they include those headers.

Please download it again (if possible).


--
Thanks & Regards,


Ashesh Vashi
EnterpriseDB INDIA:
Enterprise PostgreSQL Company

 

http://www.linkedin.com/in/asheshvashi



On Thu, Jan 6, 2011 at 10:25 PM, Jasmin Dizdarevic <jasmin.dizdarevic@gmail.com> wrote:
From http://www.enterprisedb.com/products/pgbindownload.do two weeks ago.


2011/1/6 Ashesh Vashi <ashesh.vashi@enterprisedb.com>
From where did you get it?


--
Thanks & Regards,


Ashesh Vashi
EnterpriseDB INDIA:
Enterprise PostgreSQL Company

 

http://www.linkedin.com/in/asheshvashi



On Thu, Jan 6, 2011 at 10:20 PM, Jasmin Dizdarevic <jasmin.dizdarevic@gmail.com> wrote:
unpacked zip. version is 8.4
should i build it from source?


2011/1/6 Ashesh Vashi <ashesh.vashi@enterprisedb.com>
how did you install it?


--
Thanks & Regards,


Ashesh Vashi
EnterpriseDB INDIA:
Enterprise PostgreSQL Company

 

http://www.linkedin.com/in/asheshvashi



On Thu, Jan 6, 2011 at 10:15 PM, Jasmin Dizdarevic <jasmin.dizdarevic@gmail.com> wrote:
the directory is there, but no gram.h.

2011/1/6 Ashesh Vashi <ashesh.vashi@enterprisedb.com>

Do you have %PGDIR%/include/postgresql/server/parser directory which contains gram.h?


--
Thanks & Regards,


Ashesh Vashi
EnterpriseDB INDIA:
Enterprise PostgreSQL Company

 

http://www.linkedin.com/in/asheshvashi



On Thu, Jan 6, 2011 at 10:04 PM, Jasmin Dizdarevic <jasmin.dizdarevic@gmail.com> wrote:
Hi, 

since this patch is applied, i can't build pgAdmin. %pgdir%\include\server\parser doesn't contain a gram.h file. 
What I'm doing wrong?

Ty
Jasmin

2011/1/5 Magnus Hagander <magnus@hagander.net>

On Wed, Jan 5, 2011 at 06:05, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:


On Wed, Jan 5, 2011 at 12:37 AM, Magnus Hagander <magnus@hagander.net> wrote:
On Tue, Jan 4, 2011 at 18:46, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Magnus/Dave,

This check-in has added one compilation error.
The following line introduce an error in file 'pgadmin/db/keywords.c'
#include <server/parser/gram.h>
#include <server/parser/kwlist.h>


Because - these header files does not always find under `pg_config --includedir` folder, but can be found under `pg_config --pkgincludedir`.

Please find the patch to resolve the issue. This applies on both master and REL-1_12_PATCHES branch.


Looks good in general, but do we actually need to put it on 1.12? The keyword build changes were only applied to master, so unless we actually *need* it on the back branch, I don't think we should put it there.  Is it needed for something else as well?
You're right.
This patch should only be applied on master.

 Thanks, confirmed and applied.



--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/