Re: pgAdmin III commit: Pull keywords dynamically from PostgreSQL headers - Mailing list pgadmin-hackers

From Ashesh Vashi
Subject Re: pgAdmin III commit: Pull keywords dynamically from PostgreSQL headers
Date
Msg-id AANLkTi=3YNU4s7EFziFtEKkMmeq1tkjONTCoiG4BCO4w@mail.gmail.com
Whole thread Raw
In response to pgAdmin III commit: Pull keywords dynamically from PostgreSQL headers  (Magnus Hagander <magnus@hagander.net>)
Responses Re: pgAdmin III commit: Pull keywords dynamically from PostgreSQL headers
List pgadmin-hackers
Hi Magnus/Dave,

This check-in has added one compilation error.
The following line introduce an error in file 'pgadmin/db/keywords.c'
#include <server/parser/gram.h>
#include <server/parser/kwlist.h>


Because - these header files does not always find under `pg_config --includedir` folder, but can be found under `pg_config --pkgincludedir`.

Please find the patch to resolve the issue. This applies on both master and REL-1_12_PATCHES branch.

--
Thanks & Regards,


Ashesh Vashi
EnterpriseDB INDIA:
Enterprise PostgreSQL Company

 

http://www.linkedin.com/in/asheshvashi



On Thu, Dec 30, 2010 at 1:47 PM, Magnus Hagander <magnus@hagander.net> wrote:
Pull keywords dynamically from PostgreSQL headers

Instead of copying header information into files in pgadmin,
pull the data from PostgreSQL header files.

The keywords for EnterpriseDB and Greenplum databases are still
hardcoded in pgAdmin.

Branch
------
master

Details
-------
http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=161afbde23dd05976de02d759c0bf06023a175c2

Modified Files
--------------
pgadmin/db/keywords.c             |  521 +++++++------------------------------
pgadmin/include/parser/keywords.h |  448 +-------------------------------
pgadmin/utils/misc.cpp            |   16 +-
3 files changed, 111 insertions(+), 874 deletions(-)


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Attachment

pgadmin-hackers by date:

Previous
From: Jasmin Dizdarevic
Date:
Subject: Re: Step ordering pgAgent
Next
From: Magnus Hagander
Date:
Subject: Re: pgAdmin III commit: Pull keywords dynamically from PostgreSQL headers