Postgres Pro
Downloads
Home   >   mailing lists

Re: pgAdmin III commit: Pull keywords dynamically from PostgreSQL headers - Mailing list pgadmin-hackers

From Magnus Hagander
Subject Re: pgAdmin III commit: Pull keywords dynamically from PostgreSQL headers
Date
Msg-id AANLkTinewPvjR6QxkBCFAqECohTs83+=Xi-b888HP1HJ@mail.gmail.com
Whole thread Raw
In response to Re: pgAdmin III commit: Pull keywords dynamically from PostgreSQL headers  (Ashesh Vashi <ashesh.vashi@enterprisedb.com>)
Responses Re: pgAdmin III commit: Pull keywords dynamically from PostgreSQL headers
List pgadmin-hackers
Tree view
On Tue, Jan 4, 2011 at 18:46, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Magnus/Dave,

This check-in has added one compilation error.
The following line introduce an error in file 'pgadmin/db/keywords.c'
#include <server/parser/gram.h>
#include <server/parser/kwlist.h>

Because - these header files does not always find under `pg_config --includedir` folder, but can be found under `pg_config --pkgincludedir`.

Please find the patch to resolve the issue. This applies on both master and REL-1_12_PATCHES branch.


Looks good in general, but do we actually need to put it on 1.12? The keyword build changes were only applied to master, so unless we actually *need* it on the back branch, I don't think we should put it there.  Is it needed for something else as well?



--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

pgadmin-hackers by date:

Previous
From: Ashesh Vashi
Date:
Subject: Re: pgAdmin III commit: Pull keywords dynamically from PostgreSQL headers
Next
From: "pgAdmin Trac"
Date:
Subject: [pgAdmin III] #296: Uncalled CREATE OR REPLACE VIEW in privileges dialog