Thread: Again, the requirement of password of dlgUser.cpp
Hi Andreas.
I have this requirement said by a user many times.:-(
We should hide password which it is inputted from.
--- src/ui/common/dlgUser.xrc.orig Tue Mar 15 10:25:19 2005
+++ src/ui/common/dlgUser.xrc Tue Mar 15 10:26:02 2005
@@ -25,6 +25,7 @@
<object class="wxStaticText" name="stPasswd">
<label>Password</label>
<pos>5,37d</pos>
+ <style>wxTE_PASSWORD</style>
</object>
<object class="wxTextCtrl" name="txtPasswd">
<pos>70,35d</pos>
You said that it was meaningless because there was SQL which did
reverse in the SQL Frame. but, meaning is different from it. user will
make it "password_encryption = true" of postgresql.conf. Then, when
it is inputted, it is made to be disappointed.:-(
This is strongly required.
regards,
Hiroshi Saito
> -----Original Message----- > From: Hiroshi Saito [mailto:saito@inetrt.skcapi.co.jp] > Sent: 16 March 2005 00:23 > To: Andreas Pflug > Cc: pgadmin-hackers@postgresql.org; Dave Page > Subject: Again, the requirement of password of dlgUser.cpp > > Hi Andreas. > > I have this requirement said by a user many times.:-( > We should hide password which it is inputted from. > > --- src/ui/common/dlgUser.xrc.orig Tue Mar 15 10:25:19 2005 > +++ src/ui/common/dlgUser.xrc Tue Mar 15 10:26:02 2005 > @@ -25,6 +25,7 @@ > <object class="wxStaticText" name="stPasswd"> > <label>Password</label> > <pos>5,37d</pos> > + <style>wxTE_PASSWORD</style> > </object> > <object class="wxTextCtrl" name="txtPasswd"> > <pos>70,35d</pos> > > You said that it was meaningless because there was SQL which did > reverse in the SQL Frame. but, meaning is different from it. > user will > make it "password_encryption = true" of postgresql.conf. Then, when > it is inputted, it is made to be disappointed.:-( > This is strongly required. OK, I'll agree with that - the password is not shown in the SQL pane by default these days. However - we need to improve your patch Hiroshi: 1) You should add the style to txtPasswd, not stPasswd :-) 2) Because it cannot be seen anymore, it should be confirmed - so, can you add a 'Confirm Password' textbox with the appropriate code as well please? Thanks, Dave
Hi Dave. > OK, I'll agree with that - the password is not shown in the SQL pane by > default these days. > > However - we need to improve your patch Hiroshi: > > 1) You should add the style to txtPasswd, not stPasswd :-) Uga.. it is was lost. > 2) Because it cannot be seen anymore, it should be confirmed - so, can > you add a 'Confirm Password' textbox with the appropriate code as well > please? Is this good? Thank you.!:-) regards, Hiroshi Saito
Attachment
Hiroshi Saito wrote: >>2) Because it cannot be seen anymore, it should be confirmed ???? Just look at the SQL page... Regards, Andreas
From: "Andreas Pflug" <pgadmin@pse-consulting.de> > Hiroshi Saito wrote: > > >>2) Because it cannot be seen anymore, it should be confirmed > > ???? > > Just look at the SQL page... Um, User knows how to use pgAdmin, and he won't particularly see it. In the input of the password. Probably. regards, Hiroshi Saito
-----Original Message----- From: Andreas Pflug [mailto:pgadmin@pse-consulting.de] Sent: Wed 3/16/2005 5:44 PM To: Hiroshi Saito Cc: Dave Page; pgadmin-hackers@postgresql.org Subject: Re: [pgadmin-hackers] Again, the requirement of password of dlgUser.cpp Hiroshi Saito wrote: >>2) Because it cannot be seen anymore, it should be confirmed > ???? It cannot be seen on frmMain because that shows the encrypted password. > Just look at the SQL page... Yes, it is shown there, but as long as you don't view that tab, the casual observer will not be able to see the password.Few people are ever likely to look at that tab imnsho - even I only do when debugging. I see no reason /not/ to include this patch - especially as Hiroshi has had multiple requests for it (as have I in the past). I will properly review it as soon as I can. Regards, Dave.
Dave Page wrote: > I see no reason /not/ to include this patch - especially as Hiroshi has had multiple requests for it (as have I in thepast). > > I will properly review it as soon as I can. I however don't see a need for a duplicate input. If in doubt, it can be checked. Regards, Andreas
From: "Andreas Pflug" <pgadmin@pse-consulting.de> > > I however don't see a need for a duplicate input. If in doubt, it can be > checked. No, fellow watching it behind you. regards, Hiroshi Saito
> -----Original Message----- > From: Hiroshi Saito [mailto:saito@inetrt.skcapi.co.jp] > Sent: 16 March 2005 17:42 > To: Dave Page; Andreas Pflug > Cc: pgadmin-hackers@postgresql.org > Subject: Re: Again, the requirement of password of dlgUser.cpp > > Hi Dave. > > > OK, I'll agree with that - the password is not shown in the > SQL pane by > > default these days. > > > > However - we need to improve your patch Hiroshi: > > > > 1) You should add the style to txtPasswd, not stPasswd :-) > > Uga.. it is was lost. > > > 2) Because it cannot be seen anymore, it should be > confirmed - so, can > > you add a 'Confirm Password' textbox with the appropriate > code as well > > please? > > Is this good? > > Thank you.!:-) Thanks Hiroshi, patch applied. Regards, Dave.