Re: walreceiver is uninterruptible on win32 - Mailing list pgsql-hackers

From Magnus Hagander
Subject Re: walreceiver is uninterruptible on win32
Date
Msg-id o2g9837222c1004150045h32da37dcv975c7ad70f576143@mail.gmail.com
Whole thread Raw
In response to Re: walreceiver is uninterruptible on win32  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Thu, Apr 15, 2010 at 4:17 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Magnus Hagander <magnus@hagander.net> writes:
>> Looking at the call-sites, there are bugs now - if PQexec() returns
>> NULL, we don't deal with it. It also doesn't always free the result
>> properly. I've added checks for that.
>
> I think you're just adding useless complexity there.  PQresultStatus
> defends itself just fine against a NULL input, and most other libpq
> functions likewise.

Yeah, I realized that after posting it. I was still stuck in ancient
times when at least some of those functions couldn't be called with
NULL pointers, so I just put that in there by default :-)


-- Magnus HaganderMe: http://www.hagander.net/Work: http://www.redpill-linpro.com/


pgsql-hackers by date:

Previous
From: Simon Riggs
Date:
Subject: Re: Thoughts on pg_hba.conf rejection
Next
From: Magnus Hagander
Date:
Subject: Re: walreceiver is uninterruptible on win32