Postgres Pro
Downloads
Home   >   mailing lists

Re: walreceiver is uninterruptible on win32 - Mailing list pgsql-hackers

From Tom Lane
Subject Re: walreceiver is uninterruptible on win32
Date
Msg-id 20733.1271297859@sss.pgh.pa.us
Whole thread Raw
In response to Re: walreceiver is uninterruptible on win32  (Magnus Hagander <magnus@hagander.net>)
Responses Re: walreceiver is uninterruptible on win32  (Magnus Hagander <magnus@hagander.net>)
List pgsql-hackers
Tree view 
Magnus Hagander <magnus@hagander.net> writes:
> Looking at the call-sites, there are bugs now - if PQexec() returns
> NULL, we don't deal with it. It also doesn't always free the result
> properly. I've added checks for that.

I think you're just adding useless complexity there.  PQresultStatus
defends itself just fine against a NULL input, and most other libpq
functions likewise.
        regards, tom lane

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Streaming replication and a disk full in primary
Next
From: Tom Lane
Date:
Subject: Re: Thoughts on pg_hba.conf rejection