Re: regexp character class locale awareness patch - Mailing list pgsql-hackers

From Manuel Sugawara
Subject Re: regexp character class locale awareness patch
Date
Msg-id m3n0w1gcef.fsf@dep4.fciencias.unam.mx
Whole thread Raw
In response to Re: regexp character class locale awareness patch  (Alvaro Herrera <alvherre@atentus.com>)
List pgsql-hackers
Alvaro Herrera <alvherre@atentus.com> writes:

> En 17 Apr 2002 22:53:32 -0600
> Manuel Sugawara <masm@fciencias.unam.mx> escribió:
>
> > Bruce Momjian <pgman@candle.pha.pa.us> writes:
> >
> > > Tatsuo Ishii wrote:
> > > > > I miss that case :-(. Here is the pached patch.
> > > > >
> > > > > Regards,
> > > > > Manuel.
> > > >
> > > > I also suggest that cclass_init() is called only if the locale is not
> > > > "C".
> > >
> > > OK, patch on hold while this is addressed.
> >
> > Here is a patch which addresses Tatsuo's concerns (it does return an
> > static struct instead of constructing it).
>
> Is there a reason to use "" instead of NULL in the "multis" member of
> that static struct?

Yes, read the code.

Regards,
Manuel.


pgsql-hackers by date:

Previous
From: Michael Loftis
Date:
Subject: Re: Index Scans become Seq Scans after VACUUM ANALYSE
Next
From: Alexandre Dulaunoy
Date:
Subject: Re: new food for the contrib/ directory